From: Jakub Kicinski <kuba@kernel•org>
To: Breno Leitao <leitao@debian•org>
Cc: fw@strlen•de, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
David Ahern <dsahern@kernel•org>, Shuah Khan <shuah@kernel•org>,
rbc@meta•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, netfilter-devel@vger•kernel.org,
"open list:NETFILTER" <coreteam@netfilter•org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger•kernel.org>
Subject: Re: [PATCH nf-next v3 1/2] netfilter: Make IP_NF_IPTABLES_LEGACY selectable
Date: Thu, 29 Aug 2024 07:53:03 -0700 [thread overview]
Message-ID: <20240829075303.775fce1d@kernel.org> (raw)
In-Reply-To: <ZtBIgekUyptmCqRa@gmail.com>
On Thu, 29 Aug 2024 03:08:01 -0700 Breno Leitao wrote:
> > There are various configs in the tree. Grep for the configs you convert
> > from select to depends on, they will all need updating.
>
> I am looking at all files that depend on these Kconfig options, and
> there are a lot of tests.
>
> Thinking more about the problem, it doesn't seem to be a good idea to
> change dependency from all NF modules to NF_IPTABLES_LEGACY. In other
> words, the `s/selects/depends on/` is the part that is causing all this
> hassle, and it seems unnecessary.
>
> That said, I would suggest we do not change the dependency, and keep the
> "select NF_IPTABLES_LEGACY", and keep NF_IPTABLES_LEGACY user selectable.
Good idea, sounds much simpler!
next prev parent reply other threads:[~2024-08-29 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 14:52 [PATCH nf-next v3 0/2] netfilter: Make IP_NF_IPTABLES_LEGACY selectable Breno Leitao
2024-08-27 14:52 ` [PATCH nf-next v3 1/2] " Breno Leitao
2024-08-28 14:42 ` Jakub Kicinski
2024-08-28 15:05 ` Breno Leitao
2024-08-28 18:41 ` Jakub Kicinski
2024-08-29 10:08 ` Breno Leitao
2024-08-29 14:53 ` Jakub Kicinski [this message]
2024-08-29 15:03 ` Breno Leitao
2024-08-27 14:52 ` [PATCH nf-next v3 2/2] netfilter: Make IP6_NF_IPTABLES_LEGACY selectable Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829075303.775fce1d@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=kadlec@netfilter$(echo .)org \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=rbc@meta$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox