Subject: Re: [PATCH net-next v2] net: ipa: make use of dev_err_cast_probe()

From: Simon Horman <[email-masked]>
Date: Mon, 2 Sep 2024 09:56:57 +0100

On Thu, Aug 29, 2024 at 11:07:39AM +0800, Yuesong Li wrote:
> Using dev_err_cast_probe() to simplify the code.
> 
> Signed-off-by: Yuesong Li <[email-masked]>
> Signed-off-by: Hongbo Li <[email-masked]>
> ---
> v2: https://lore.kernel.org/all/[email-masked]/
>   - fix patch name
>   - drop the {} and fix the alignment

Thanks for hte updates.

I note that this code is in a probe function,
so this patch is an appropriate use of dev_err_cast_probe() [1].

I also see that it addresses the feedback on code style from v1.

Reviewed-by: Simon Horman <[email-masked]>

[1] [PATCH] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
    https://lore.kernel.org/netdev/[email-masked]/

...