From: Vasileios Amoiridis <vassilisamir@gmail•com>
To: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Cc: Vasileios Amoiridis <vassilisamir@gmail•com>,
linux@armlinux•org.uk, maarten.lankhorst@linux•intel.com,
mripard@kernel•org, tzimmermann@suse•de, airlied@gmail•com,
daniel@ffwll•ch, linus.walleij@linaro•org, alsi@bang-olufsen•dk,
andrew@lunn•ch, f.fainelli@gmail•com, olteanv@gmail•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, nico@fluxnic•net,
arend.vanspriel@broadcom•com, kvalo@kernel•org, robh@kernel•org,
saravanak@google•com, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
brcm80211@lists•linux.dev, brcm80211-dev-list.pdl@broadcom•com,
devicetree@vger•kernel.org
Subject: Re: [PATCH v1 6/7] wifi: wlcore: sdio: Make use of irq_get_trigger_type()
Date: Wed, 4 Sep 2024 16:53:46 +0200 [thread overview]
Message-ID: <20240904145346.GA68482@vamoiridPC> (raw)
In-Reply-To: <ZtchHGEBtn-BVB-l@smile.fi.intel.com>
On Tue, Sep 03, 2024 at 05:45:48PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 03, 2024 at 12:55:33AM +0200, Vasileios Amoiridis wrote:
> > Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> > simple irq_get_trigger_type(irq).
>
> ...
>
> > memset(res, 0x00, sizeof(res));
> >
> > res[0].start = irq;
> > - res[0].flags = IORESOURCE_IRQ |
> > - irqd_get_trigger_type(irq_get_irq_data(irq));
> > + res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> > res[0].name = "irq";
>
>
> > if (wakeirq > 0) {
> > res[1].start = wakeirq;
> > - res[1].flags = IORESOURCE_IRQ |
> > - irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> > + res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
> > res[1].name = "wakeirq";
> > num_irqs = 2;
>
> Since you are touching a lot here, consider also using macros from ioport.h,
> i.e. DEFINE_RES_IRQ_NAMED().
>
> This will become something like
>
> res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
> res[0].flags |= irq_get_trigger_type(irq);
>
> if (wakeirq > 0) {
> res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
> res[1].flags |= irq_get_trigger_type(wakeirq);
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Hi Andy,
Thank you very much for reviewing this, I will check this out
and apply the proposed changes to this and the next one.
Cheers,
Vasilis
next prev parent reply other threads:[~2024-09-04 14:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 22:55 [PATCH v1 0/7] Use functionality of irq_get_trigger_type() Vasileios Amoiridis
2024-09-02 22:55 ` [PATCH v1 1/7] drm/i2c: tda998x: Make use " Vasileios Amoiridis
2024-09-02 22:55 ` [PATCH v1 2/7] net: dsa: realtek: rtl8365mb: " Vasileios Amoiridis
2024-09-02 23:38 ` Alvin Šipraga
2024-09-02 22:55 ` [PATCH v1 3/7] net: dsa: realtek: rtl8366rb: " Vasileios Amoiridis
2024-09-02 23:38 ` Alvin Šipraga
2024-09-05 11:39 ` Linus Walleij
2024-09-02 22:55 ` [PATCH v1 4/7] net: smc91x: " Vasileios Amoiridis
2024-09-02 22:55 ` [PATCH v1 5/7] wifi: brcmfmac: of: " Vasileios Amoiridis
2024-09-03 17:13 ` Kalle Valo
2024-09-02 22:55 ` [PATCH v1 6/7] wifi: wlcore: sdio: " Vasileios Amoiridis
2024-09-03 14:45 ` Andy Shevchenko
2024-09-04 14:53 ` Vasileios Amoiridis [this message]
2024-09-02 22:55 ` [PATCH v1 7/7] of/irq: " Vasileios Amoiridis
2024-09-03 7:09 ` Krzysztof Kozlowski
2024-09-03 14:39 ` Rob Herring (Arm)
2024-09-03 14:58 ` Andy Shevchenko
2024-09-03 18:59 ` Rob Herring
2024-09-03 14:48 ` Andy Shevchenko
2024-09-03 0:22 ` [PATCH v1 0/7] Use functionality " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904145346.GA68482@vamoiridPC \
--to=vassilisamir@gmail$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=alsi@bang-olufsen$(echo .)dk \
--cc=andrew@lunn$(echo .)ch \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=brcm80211@lists$(echo .)linux.dev \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mripard@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nico@fluxnic$(echo .)net \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=saravanak@google$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox