Subject: Re: [PATCH v6 net-next 07/15] net-shapers: implement shaper cleanup on queue deletion

From: Jakub Kicinski <[email-masked]>
Date: Wed, 4 Sep 2024 18:33:29 -0700

On Wed,  4 Sep 2024 15:53:39 +0200 Paolo Abeni wrote:
> +		net_shaper_set_real_num_tx_queues(dev, txq);
> +
>  		dev_qdisc_change_real_num_tx(dev, txq);
>  
>  		dev->real_num_tx_queues = txq;

The dev->lock has to be taken here, around those three lines,
and then set / group must check QUEUE ids against 
dev->real_num_tx_queues, no? Otherwise the work 
net_shaper_set_real_num_tx_queues() does is prone to races?