Subject: Re: [PATCH net-next v2 3/4] enic: Report per queue statistics in ethtool

From: Jakub Kicinski <[email-masked]>
Date: Thu, 5 Sep 2024 18:31:42 -0700

On Wed,  4 Sep 2024 18:08:59 -0700 Nelson Escobar wrote:
> Make 'ethtool -S <intf>' output show per rq/wq statistics.

> +static const struct enic_stat enic_per_wq_stats[] = {
> +	ENIC_PER_WQ_STAT(packets),
> +	ENIC_PER_WQ_STAT(stopped),

Stats for which structured APIs exist must not be added to ethtool -S
Please filter things which exist in qstat out of ethtool

please see:
https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
(it talks about rtnl_link_stats because only those existed at the time).