From: Jakub Kicinski <kuba@kernel•org>
To: Paolo Abeni <pabeni@redhat•com>
Cc: netdev@vger•kernel.org, Jiri Pirko <jiri@resnulli•us>,
Madhu Chittim <madhu.chittim@intel•com>,
Sridhar Samudrala <sridhar.samudrala@intel•com>,
Simon Horman <horms@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
Sunil Kovvuri Goutham <sgoutham@marvell•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Donald Hunter <donald.hunter@gmail•com>,
anthony.l.nguyen@intel•com, przemyslaw.kitszel@intel•com,
intel-wired-lan@lists•osuosl.org, edumazet@google•com
Subject: Re: [PATCH v6 net-next 07/15] net-shapers: implement shaper cleanup on queue deletion
Date: Fri, 6 Sep 2024 07:56:27 -0700 [thread overview]
Message-ID: <20240906075627.523b66f9@kernel.org> (raw)
In-Reply-To: <896b88ce-f86c-4f00-8404-cedc6a202729@redhat.com>
On Fri, 6 Sep 2024 16:49:32 +0200 Paolo Abeni wrote:
> I forgot to mention there is another, easier, alternative: keep the max
> queue id check in the drivers. The driver will have to acquire and held
> in the shaper callbacks the relevant driver-specific lock - 'crit_lock',
> in the iavf case.
>
> Would you be ok with such 2nd option?
I'd strongly prefer if you implemented what was suggested.
> Side note: I think the iavf should have to acquire such lock in the
> callbacks no matter what or access/write to the rings info could be racy.
next prev parent reply other threads:[~2024-09-06 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 13:53 [PATCH v6 net-next 00/15] net: introduce TX H/W shaping API Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 01/15] genetlink: extend info user-storage to match NL cb ctx Paolo Abeni
2024-09-05 0:40 ` Jakub Kicinski
2024-09-04 13:53 ` [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec Paolo Abeni
2024-09-05 1:03 ` Jakub Kicinski
2024-09-05 14:51 ` Paolo Abeni
2024-09-05 15:05 ` Jakub Kicinski
2024-09-05 16:17 ` Paolo Abeni
2024-09-06 0:38 ` Jakub Kicinski
2024-09-04 13:53 ` [PATCH v6 net-next 03/15] net-shapers: implement NL get operation Paolo Abeni
2024-09-05 1:11 ` Jakub Kicinski
2024-09-04 13:53 ` [PATCH v6 net-next 04/15] net-shapers: implement NL set and delete operations Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 05/15] net-shapers: implement NL group operation Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 06/15] net-shapers: implement delete support for NODE scope shaper Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 07/15] net-shapers: implement shaper cleanup on queue deletion Paolo Abeni
2024-09-05 1:33 ` Jakub Kicinski
2024-09-05 18:02 ` Paolo Abeni
2024-09-06 1:25 ` Jakub Kicinski
2024-09-06 14:25 ` Paolo Abeni
2024-09-06 14:42 ` Jakub Kicinski
2024-09-06 14:49 ` Paolo Abeni
2024-09-06 14:56 ` Jakub Kicinski [this message]
2024-09-04 13:53 ` [PATCH v6 net-next 08/15] netlink: spec: add shaper introspection support Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 09/15] net: shaper: implement " Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 10/15] net-shapers: implement cap validation in the core Paolo Abeni
2024-09-05 1:56 ` Jakub Kicinski
2024-09-04 13:53 ` [PATCH v6 net-next 11/15] testing: net-drv: add basic shaper test Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 12/15] virtchnl: support queue rate limit and quanta size configuration Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 13/15] ice: Support VF " Paolo Abeni
2024-09-04 13:53 ` [PATCH v6 net-next 14/15] iavf: Add net_shaper_ops support Paolo Abeni
2024-09-05 1:58 ` Jakub Kicinski
2024-09-04 13:53 ` [PATCH v6 net-next 15/15] iavf: add support to exchange qos capabilities Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906075627.523b66f9@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=madhu.chittim@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox