Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

From: Jakub Kicinski <[email-masked]>
Date: Fri, 13 Sep 2024 20:23:47 -0700

On Thu, 12 Sep 2024 00:44:43 -0700 Erni Sri Satya Vennela wrote:
> Add support for the ethtool get_link and get_link_ksettings
> operations. Display standard port information using ethtool.

Any reason why? Sometimes people add this callback for virtual
devices to expose some approximate speed, but you're not reporting
speed, so I'm curious.

> +static int mana_get_link_ksettings(struct net_device *ndev,
> +				   struct ethtool_link_ksettings *cmd)
> +{
> +	cmd->base.duplex = DUPLEX_FULL;

make sense

> +	cmd->base.autoneg = AUTONEG_ENABLE;

what's the point of autoneg if we show no link info?
DISABLE seems more suitable

> +	cmd->base.port = PORT_DA;

Any reason why DA? I'd think PORT_OTHER may be better?
-- 
pw-bot: cr