From: Simon Horman <horms@kernel•org>
To: Florian Westphal <fw@strlen•de>
Cc: Dan Carpenter <dan.carpenter@linaro•org>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel-janitors@vger•kernel.org
Subject: Re: [PATCH net] netfilter: nft_socket: Fix a NULL vs IS_ERR() bug in nft_socket_cgroup_subtree_level()
Date: Sat, 14 Sep 2024 16:21:52 +0100 [thread overview]
Message-ID: <20240914152152.GB11774@kernel.org> (raw)
In-Reply-To: <20240914111940.GA19902@breakpoint.cc>
On Sat, Sep 14, 2024 at 01:19:40PM +0200, Florian Westphal wrote:
> Dan Carpenter <dan.carpenter@linaro•org> wrote:
> > The cgroup_get_from_path() function never returns NULL, it returns error
> > pointers. Update the error handling to match.
>
> Good news, I will retire in the next few years so I don't send shit
> patches anymore.
>
> Acked-by: Florian Westphal <fw@strlen•de>
Everyone makes mistakes, don't be too hard on yourself :)
next prev parent reply other threads:[~2024-09-14 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 9:56 [PATCH net] netfilter: nft_socket: Fix a NULL vs IS_ERR() bug in nft_socket_cgroup_subtree_level() Dan Carpenter
2024-09-14 11:19 ` Florian Westphal
2024-09-14 15:21 ` Simon Horman [this message]
2024-09-14 22:07 ` Pablo Neira Ayuso
2024-09-15 16:01 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914152152.GB11774@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=coreteam@netfilter$(echo .)org \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=kadlec@netfilter$(echo .)org \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox