Subject: Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL

From: Simon Horman <[email-masked]>
Date: Mon, 16 Sep 2024 20:05:28 +0100

On Mon, Sep 16, 2024 at 08:04:16PM +0100, Simon Horman wrote:
> On Mon, Sep 16, 2024 at 08:54:21PM +0200, Thomas Weißschuh wrote:
> > On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote:
> > > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> > > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > > > > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > > > > only present when the dst cache is built.
> > > > > Select DST_CACHE to build the dst cache, similar to other kconfig
> > > > > options in the same file.
> > > > > 
> > > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > > > > Cc: [email-masked]
> > > > > ---
> > > > > Signed-off-by: Thomas Weißschuh <[email-masked]>
> > > > 
> > > > Reviewed-by: Simon Horman <[email-masked]>
> > > > Tested-by: Simon Horman <[email-masked]> # build-tested
> > > 
> > > Sorry Thomas, I missed one important thing:
> > > 
> > > Your Signed-off-by line needs to go above the scissors ('---')
> > > because when git applies your patch nothing below the scissors
> > > is included in the patch description.
> > 
> > Welp, this seems to be due to a combination of me forgetting to add it,
> > b4 adding it below the scissors automatically and then failing to warn
> > about the missing sign-off.

BTW, if b4 is adding it then, maybe, you need to remove
it from the cover letter using b4 prep --edit-cover

> > 
> > I'll resend v2 with your tags. And will also remove the Cc: stable as
> > per net rules.
> 
> Thanks. Please be aware of the 24h rule.
> 
> https://docs.kernel.org/process/maintainer-netdev.html
>