From: Simon Horman <horms@kernel•org>
To: Markus Elfring <Markus.Elfring@web•de>
Cc: netdev@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
Clayton Rayment <clayton.rayment@xilinx•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Michal Simek <michal.simek@amd•com>,
Paolo Abeni <pabeni@redhat•com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd•com>,
LKML <linux-kernel@vger•kernel.org>,
Julia Lawall <julia.lawall@inria•fr>
Subject: Re: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write()
Date: Sun, 22 Sep 2024 18:05:07 +0100 [thread overview]
Message-ID: <20240922170507.GD3426578@kernel.org> (raw)
In-Reply-To: <330c2b9e-9a15-4442-8288-07f66760f856@web.de>
On Fri, Sep 20, 2024 at 01:01:45PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users•sourceforge.net>
> Date: Fri, 20 Sep 2024 12:43:39 +0200
> Subject: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write()
>
> Add a label so that a bit of exception handling can be better reused
> at the end of this function implementation.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users•sourceforge.net>
Hi Markus,
This change seems reasonable to me. However, I am assuming that as a
non-bug-fix, this is targeted at net-next. And net-next is currently
closed for the v6.12 merge window. Please consider reposting this patch
once net-next reopens. That will occur after v6.12-rc1 has been released.
Which I expect to be about a week from now.
Also, for networking patches please tag non-bug fixes for
net-next (and bug fixes for net, being sure to include a Fixes tag).
Subject: [PATCH net-next] ...
Please see https://docs.kernel.org/process/maintainer-netdev.html
...
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
...
> @@ -153,12 +151,9 @@ static int axienet_mdio_write(struct mii_bus *bus, int phy_id, int reg,
> XAE_MDIO_MCR_OP_WRITE_MASK));
>
> ret = axienet_mdio_wait_until_ready(lp);
> - if (ret < 0) {
> - axienet_mdio_mdc_disable(lp);
> - return ret;
> - }
Please add a blank line here.
> +disable_mdc:
> axienet_mdio_mdc_disable(lp);
> - return 0;
> + return ret;
> }
>
> /**
--
pw-bot: defer
next prev parent reply other threads:[~2024-09-22 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 11:01 [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write() Markus Elfring
2024-09-22 17:05 ` Simon Horman [this message]
2024-09-22 17:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922170507.GD3426578@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Markus.Elfring@web$(echo .)de \
--cc=clayton.rayment@xilinx$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=julia.lawall@inria$(echo .)fr \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michal.simek@amd$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=radhey.shyam.pandey@amd$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox