Subject: Re: [RFC net-next 1/1] hv_netvsc: Link queues to NAPIs

From: Simon Horman <[email-masked]>
Date: Thu, 26 Sep 2024 16:10:24 +0100

On Tue, Sep 24, 2024 at 11:48:51PM +0000, Joe Damato wrote:
> Use netif_queue_set_napi to link queues to NAPI instances so that they
> can be queried with netlink.
> 
> Signed-off-by: Joe Damato <[email-masked]>
> ---
>  drivers/net/hyperv/netvsc.c       | 11 ++++++++++-
>  drivers/net/hyperv/rndis_filter.c |  9 +++++++--
>  2 files changed, 17 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index 2b6ec979a62f..ccaa4690dba0 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -712,8 +712,11 @@ void netvsc_device_remove(struct hv_device *device)
>  	for (i = 0; i < net_device->num_chn; i++) {
>  		/* See also vmbus_reset_channel_cb(). */
>  		/* only disable enabled NAPI channel */
> -		if (i < ndev->real_num_rx_queues)
> +		if (i < ndev->real_num_rx_queues) {
> +			netif_queue_set_napi(ndev, i, NETDEV_QUEUE_TYPE_TX, NULL);
> +			netif_queue_set_napi(ndev, i, NETDEV_QUEUE_TYPE_RX, NULL);

Hi Joe,

When you post a non-RFC version of this patch, could you consider
line-wrapping the above to 80 columns, as is still preferred for
Networking code?

There is an option to checkpatch that will warn you about this.

...