Subject: Re: [PATCH net-next 06/15] net: sparx5: add constants to match data

From: Jakub Kicinski <[email-masked]>
Date: Wed, 2 Oct 2024 07:33:52 -0700

On Wed, 2 Oct 2024 13:31:32 +0000 Daniel Machon wrote:
> By "type the code out" - are you saying that we should not be using a macro
> for accessing the const at all? and rather just:
> 
>     struct sparx5_consts *consts = sparx5->data->consts;
>     consts->some_var

This.

> or pass in the sparx5 pointer to the macro too, which was the concert that
> Jacob raised.

The implicit arguments are part of the ugliness, and should also go
away. But in this case the entire macro should go.