From: Simon Horman <horms@kernel•org>
To: Danielle Ratson <danieller@nvidia•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, yuehaibing@huawei•com,
linux-kernel@vger•kernel.org, petrm@nvidia•com
Subject: Re: [PATCH net-next v4 0/2] ethtool: Add support for writing firmware
Date: Thu, 3 Oct 2024 14:53:54 +0100 [thread overview]
Message-ID: <20241003135354.GP1310185@kernel.org> (raw)
In-Reply-To: <20241001124150.1637835-1-danieller@nvidia.com>
On Tue, Oct 01, 2024 at 03:41:48PM +0300, Danielle Ratson wrote:
> In the CMIS specification for pluggable modules, LPL (Local Payload) and
> EPL (Extended Payload) are two types of data payloads used for managing
> various functions and features of the module.
>
> EPL payloads are used for more complex and extensive management functions
> that require a larger amount of data, so writing firmware blocks using EPL
> is much more efficient.
>
> Currently, only LPL payload is supported for writing firmware blocks to
> the module.
>
> Add support for writing firmware block using EPL payload, both to support
> modules that support only EPL write mechanism, and to optimize the flashing
> process of modules that support LPL and EPL.
>
> Running the flashing command on the same sample module using EPL vs. LPL
> showed an improvement of 84%.
>
> Patchset overview:
> Patch #1: preparations
> Patch #2: Add EPL support
>
> v4: Resending the right version after wrong v3.
Thanks, this one looks good :)
>
> v2:
> * Fix the commit meassges to align the cover letter about the
> right meaning of LPL and EPL.
> Patch #2:
> * Initialize the variable 'bytes_written' before the first
> iteration.
>
> Danielle Ratson (2):
> net: ethtool: Add new parameters and a function to support EPL
> net: ethtool: Add support for writing firmware blocks using EPL
> payload
>
> net/ethtool/cmis.h | 16 ++++--
> net/ethtool/cmis_cdb.c | 94 +++++++++++++++++++++++++-----
> net/ethtool/cmis_fw_update.c | 108 +++++++++++++++++++++++++++++------
> 3 files changed, 184 insertions(+), 34 deletions(-)
>
> --
> 2.45.0
>
next prev parent reply other threads:[~2024-10-03 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 12:41 [PATCH net-next v4 0/2] ethtool: Add support for writing firmware Danielle Ratson
2024-10-01 12:41 ` [PATCH net-next v4 1/2] net: ethtool: Add new parameters and a function to support EPL Danielle Ratson
2024-10-01 12:41 ` [PATCH net-next v4 2/2] net: ethtool: Add support for writing firmware blocks using EPL payload Danielle Ratson
2024-10-03 13:53 ` Simon Horman [this message]
2024-10-08 15:11 ` [PATCH net-next v4 0/2] ethtool: Add support for writing firmware Jakub Kicinski
2024-10-09 7:08 ` Danielle Ratson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003135354.GP1310185@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox