From: Jakub Kicinski <kuba@kernel•org>
To: Mina Almasry <almasrymina@google•com>
Cc: Brett Creeley <bcreeley@amd•com>, Taehee Yoo <ap420073@gmail•com>,
davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
netdev@vger•kernel.org, linux-doc@vger•kernel.org,
donald.hunter@gmail•com, corbet@lwn•net,
michael.chan@broadcom•com, kory.maincent@bootlin•com,
andrew@lunn•ch, maxime.chevallier@bootlin•com,
danieller@nvidia•com, hengqi@linux•alibaba.com,
ecree.xilinx@gmail•com, przemyslaw.kitszel@intel•com,
hkallweit1@gmail•com, ahmed.zaki@intel•com,
paul.greenwalt@intel•com, rrameshbabu@nvidia•com,
idosch@nvidia•com, asml.silence@gmail•com, kaiyuanz@google•com,
willemb@google•com, aleksander.lobakin@intel•com, dw@davidwei•uk,
sridhar.samudrala@intel•com
Subject: Re: [PATCH net-next v3 5/7] net: devmem: add ring parameter filtering
Date: Tue, 8 Oct 2024 12:28:20 -0700 [thread overview]
Message-ID: <20241008122820.71f67378@kernel.org> (raw)
In-Reply-To: <CAHS8izPmg8CJNYVQfdJB9BoyE75qf+wrz_68pTDdYffpEWDQMg@mail.gmail.com>
On Thu, 3 Oct 2024 11:49:50 -0700 Mina Almasry wrote:
> > > + dev->ethtool_ops->get_ringparam(dev, &ringparam,
> > > + &kernel_ringparam, extack);
> > > + if (kernel_ringparam.tcp_data_split != ETHTOOL_TCP_DATA_SPLIT_ENABLED ||
> > > + kernel_ringparam.tcp_data_split_thresh) {
> > > + NL_SET_ERR_MSG(extack,
> > > + "tcp-header-data-split is disabled or threshold is not zero");
> > > + return -EINVAL;
> > > + }
> > > +
> > Maybe just my personal opinion, but IMHO these checks should be separate
> > so the error message can be more concise/clear.
> >
>
> Good point. The error message in itself is valuable.
If you mean that the error message is more intuitive than debugging why
PP_FLAG_ALLOW_UNREADABLE_NETMEM isn't set - I agree :)
I vote to keep the patch, FWIW. Maybe add a comment that for now drivers
should not set PP_FLAG_ALLOW_UNREADABLE_NETMEM, anyway, but this gives
us better debuggability, and in the future we may find cases where
doing a copy is cheaper than buffer circulation (and therefore may lift
this check).
next prev parent reply other threads:[~2024-10-08 19:28 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:06 [PATCH net-next v3 0/7] bnxt_en: implement device memory TCP for bnxt Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 1/7] bnxt_en: add support for rx-copybreak ethtool command Taehee Yoo
2024-10-03 16:57 ` Brett Creeley
2024-10-03 17:15 ` Taehee Yoo
2024-10-03 17:13 ` Michael Chan
2024-10-03 17:22 ` Taehee Yoo
2024-10-03 17:43 ` Michael Chan
2024-10-03 18:28 ` Taehee Yoo
2024-10-03 18:34 ` Andrew Lunn
2024-10-05 6:29 ` Taehee Yoo
2024-10-08 18:10 ` Jakub Kicinski
2024-10-08 19:38 ` Michael Chan
2024-10-08 19:53 ` Jakub Kicinski
2024-10-08 20:35 ` Michael Chan
2024-10-03 16:06 ` [PATCH net-next v3 2/7] bnxt_en: add support for tcp-data-split " Taehee Yoo
2024-10-08 18:19 ` Jakub Kicinski
2024-10-09 13:54 ` Taehee Yoo
2024-10-09 15:28 ` Jakub Kicinski
2024-10-09 17:47 ` Taehee Yoo
2024-10-31 17:34 ` Taehee Yoo
2024-10-31 23:56 ` Jakub Kicinski
2024-11-01 17:11 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 3/7] net: ethtool: add support for configuring tcp-data-split-thresh Taehee Yoo
2024-10-03 18:25 ` Mina Almasry
2024-10-03 19:33 ` Taehee Yoo
2024-10-04 1:47 ` Mina Almasry
2024-10-05 6:11 ` Taehee Yoo
2024-10-08 18:33 ` Jakub Kicinski
2024-10-09 14:25 ` Taehee Yoo
2024-10-09 15:46 ` Jakub Kicinski
2024-10-09 17:49 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 4/7] bnxt_en: add support for tcp-data-split-thresh ethtool command Taehee Yoo
2024-10-03 18:13 ` Brett Creeley
2024-10-03 19:13 ` Taehee Yoo
2024-10-08 18:35 ` Jakub Kicinski
2024-10-09 14:31 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 5/7] net: devmem: add ring parameter filtering Taehee Yoo
2024-10-03 18:29 ` Mina Almasry
2024-10-04 3:57 ` Taehee Yoo
2024-10-03 18:35 ` Brett Creeley
2024-10-03 18:49 ` Mina Almasry
2024-10-08 19:28 ` Jakub Kicinski [this message]
2024-10-09 14:35 ` Taehee Yoo
2024-10-04 4:01 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 6/7] net: ethtool: " Taehee Yoo
2024-10-03 18:32 ` Mina Almasry
2024-10-03 19:35 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 7/7] bnxt_en: add support for device memory tcp Taehee Yoo
2024-10-03 18:43 ` Mina Almasry
2024-10-04 10:34 ` Taehee Yoo
2024-10-08 2:57 ` David Wei
2024-10-09 15:02 ` Taehee Yoo
2024-10-08 19:50 ` Jakub Kicinski
2024-10-09 15:37 ` Taehee Yoo
2024-10-10 0:01 ` Jakub Kicinski
2024-10-10 17:44 ` Mina Almasry
2024-10-11 1:34 ` Jakub Kicinski
2024-10-11 17:33 ` Mina Almasry
2024-10-11 23:42 ` Jason Gunthorpe
2024-10-14 22:38 ` Mina Almasry
2024-10-15 0:16 ` Jakub Kicinski
2024-10-15 1:10 ` Mina Almasry
2024-10-15 12:44 ` Jason Gunthorpe
2024-10-18 8:25 ` Mina Almasry
2024-10-19 13:55 ` Taehee Yoo
2024-10-15 14:29 ` Pavel Begunkov
2024-10-15 17:38 ` David Wei
2024-10-05 3:48 ` kernel test robot
2024-10-08 2:45 ` David Wei
2024-10-08 3:54 ` Taehee Yoo
2024-10-08 3:58 ` Taehee Yoo
2024-10-16 20:17 ` [PATCH net-next v3 0/7] bnxt_en: implement device memory TCP for bnxt Stanislav Fomichev
2024-10-17 8:58 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008122820.71f67378@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=ap420073@gmail$(echo .)com \
--cc=asml.silence@gmail$(echo .)com \
--cc=bcreeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dw@davidwei$(echo .)uk \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hengqi@linux$(echo .)alibaba.com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=kaiyuanz@google$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paul.greenwalt@intel$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox