Subject: Re: [PATCH net-next v4] eth: fbnic: Add hardware monitoring support via HWMON interface

From: Jakub Kicinski <[email-masked]>
Date: Wed, 9 Oct 2024 06:26:53 -0700

On Tue,  8 Oct 2024 07:32:12 -0700 Sanman Pradhan wrote:
>  	if (!fbd->dsn) {
>  		dev_warn(&pdev->dev, "Reading serial number failed\n");
> -		goto init_failure_mode;
> +		goto hwmon_unregister;
>  	}
> 
>  	netdev = fbnic_netdev_alloc(fbd);
> @@ -310,6 +312,8 @@ static int fbnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> 
>  ifm_free_netdev:
>  	fbnic_netdev_free(fbd);
> +hwmon_unregister:
> +	fbnic_hwmon_unregister(fbd);

not what I meant...
Delete these two lines and leave the goto above as is.
HWMON can remain registered even if we don't probe networking.
-- 
pw-bot: cr