Subject: Re: [PATCH] selftests: net: rds: fix module not found

From: Jakub Kicinski <[email-masked]>
Date: Wed, 9 Oct 2024 19:40:31 -0700

On Tue,  8 Oct 2024 10:22:53 +0200 Alessandro Zanni wrote:
> This fix solves this error, when calling kselftest with targets "net/rds":
> 
> selftests: net/rds: test.py
> Traceback (most recent call last):
>   File "tools/testing/selftests/net/rds/./test.py", line 17, in <module>
>     from lib.py import ip
> ModuleNotFoundError: No module named 'lib'
> 
> Signed-off-by: Alessandro Zanni <[email-masked]>
> ---
>  tools/testing/selftests/net/rds/test.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py
> index e6bb109bcead..112a8059c030 100755
> --- a/tools/testing/selftests/net/rds/test.py
> +++ b/tools/testing/selftests/net/rds/test.py
> @@ -14,8 +14,9 @@ import sys
>  import atexit
>  from pwd import getpwuid
>  from os import stat
> -from lib.py import ip
>  
> +sys.path.append("..")
> +from lib.py.utils import ip
>  
>  libc = ctypes.cdll.LoadLibrary('libc.so.6')
>  setns = libc.setns

Does this work regardless of where we try to run the script from?
In other cross-imports we try to build the path based on __file__,
see: tools/testing/selftests/drivers/net/lib/py/__init__.py

Would be good to keep consistency.
-- 
pw-bot: cr