From: Simon Horman <horms@kernel•org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle•com>
Cc: davem@davemloft•net, Liam.Howlett@oracle•com,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
mingo@redhat•com, peterz@infradead•org, juri.lelli@redhat•com,
vincent.guittot@linaro•org, dietmar.eggemann@arm•com,
rostedt@goodmis•org, bsegall@google•com, mgorman@suse•de,
vschneid@redhat•com, jiri@resnulli•us,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
akpm@linux-foundation•org, shuah@kernel•org,
linux-kselftest@vger•kernel.org, peili.io@oracle•com
Subject: Re: [PATCH net-next 2/3] connector/cn_proc: Kunit tests for threads hash table
Date: Sat, 12 Oct 2024 10:45:57 +0100 [thread overview]
Message-ID: <20241012094557.GB77519@kernel.org> (raw)
In-Reply-To: <20241012004532.2071738-3-anjali.k.kulkarni@oracle.com>
On Fri, Oct 11, 2024 at 05:45:31PM -0700, Anjali Kulkarni wrote:
> Kunit tests to test hash table add, delete, duplicate add and delete.
> Add following configs and compile kernel code:
>
> CONFIG_CONNECTOR=y
> CONFIG_PROC_EVENTS=y
> CONFIG_NET=y
> CONFIG_KUNIT=m/y
> CONFIG_CN_HASH_KUNIT_TEST=m/y
>
> To run kunit tests:
> sudo modprobe cn_hash_test
>
> Output of kunit tests and hash table contents are displayed in
> /var/log/messages (at KERN_DEBUG level).
>
> Signed-off-by: Anjali Kulkarni <anjali.k.kulkarni@oracle•com>
...
> index 000000000000..2687492864ed
> --- /dev/null
> +++ b/lib/cn_hash_test.c
> @@ -0,0 +1,167 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * KUnit test for the connector threads hashtable code.
> + *
> + * Copyright (c) 2024 Oracle and/or its affiliates.
> + * Author: Anjali Kulkarni <anjali.k.kulkarni@oracle•com>
> + */
> +#include <kunit/test.h>
> +
> +#include "cn_hash_test.h"
> +
> +#define ARR_SIZE 4
> +#define HASH_TABLE_LEN 1024
> +
> +struct add_data {
> + pid_t pid;
> + int exit_val;
> + int key;
> +};
> +
> +struct add_data adata[ARR_SIZE];
> +int key_display[HASH_TABLE_LEN];
Hi Anjali,
adata and key_display seem to only be used within this file.
Probably they should be static.
...
next prev parent reply other threads:[~2024-10-12 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 0:45 [PATCH net-next 0/3] Threads support in proc connector Anjali Kulkarni
2024-10-12 0:45 ` [PATCH net-next 1/3] connector/cn_proc: Add hash table for threads Anjali Kulkarni
2024-10-12 9:43 ` Simon Horman
2024-10-12 0:45 ` [PATCH net-next 2/3] connector/cn_proc: Kunit tests for threads hash table Anjali Kulkarni
2024-10-12 9:45 ` Simon Horman [this message]
2024-10-13 3:06 ` Anjali Kulkarni
2024-10-12 0:45 ` [PATCH net-next 3/3] connector/cn_proc: Selftest for threads Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012094557.GB77519@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Liam.Howlett@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anjali.k.kulkarni@oracle$(echo .)com \
--cc=bsegall@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dietmar.eggemann@arm$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peili.io@oracle$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=vschneid@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox