Subject: Re: [PATCH net 1/9] net: hns3: default enable tx bounce buffer when smmu enabled

From: Jakub Kicinski <[email-masked]>
Date: Tue, 15 Oct 2024 18:16:57 -0700

On Fri, 11 Oct 2024 17:45:13 +0800 Jijie Shao wrote:
> From: Peiyang Wang <[email-masked]>
> 
> When TX bounce buffer is enabled, dma map is used only when the buffer
> initialized. When spending packages, the driver only do dma sync. To

packages -> packets

> avoid SMMU prefetch, default enable tx bounce buffer if smmu enabled.

you seem to force it to be enabled, rather than just changing 
the default. That is strange. Why not let the user lower the value?

Also I don't see why this is a fix. Seems like a performance
improvement.
-- 
pw-bot: cr