From: Simon Horman <horms@kernel•org>
To: Rosen Penev <rosenp@gmail•com>
Cc: netdev@vger•kernel.org,
"Florian Fainelli" <florian.fainelli@broadcom•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Kurt Kanzenbach" <kurt@linutronix•de>,
"Woojung Huh" <woojung.huh@microchip•com>,
"maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER"
<UNGLinuxDriver@microchip•com>,
"Clément Léger" <clement.leger@bootlin•com>,
"George McCollister" <george.mccollister@gmail•com>,
"Richard Cochran" <richardcochran@gmail•com>,
"Jacob Keller" <jacob.e.keller@intel•com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre•com>,
"Breno Leitao" <leitao@debian•org>,
"open list" <linux-kernel@vger•kernel.org>,
"open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER"
<linux-renesas-soc@vger•kernel.org>
Subject: Re: [PATCHv7 net-next 6/6] net: ibm: emac: generate random MAC if not found
Date: Thu, 17 Oct 2024 09:58:53 +0100 [thread overview]
Message-ID: <20241017085853.GR2162@kernel.org> (raw)
In-Reply-To: <20241015200222.12452-8-rosenp@gmail.com>
On Tue, Oct 15, 2024 at 01:02:21PM -0700, Rosen Penev wrote:
> On this Cisco MX60W, u-boot sets the local-mac-address property.
> Unfortunately by default, the MAC is wrong and is actually located on a
> UBI partition. Which means nvmem needs to be used to grab it.
>
> In the case where that fails, EMAC fails to initialize instead of
> generating a random MAC as many other drivers do.
>
> Match behavior with other drivers to have a working ethernet interface.
>
> Signed-off-by: Rosen Penev <rosenp@gmail•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-10-17 8:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 20:02 [PATCHv7 net-next 0/6] ibm: emac: more cleanups Rosen Penev
2024-10-15 20:02 ` [PATCHv7 net-next 1/6] net: ibm: emac: use netif_receive_skb_list Rosen Penev
2024-10-15 20:02 ` [PATCH] net: memcpy to ethtool_puts Rosen Penev
2024-10-15 20:04 ` Rosen Penev
2024-10-16 13:59 ` kernel test robot
2024-10-15 20:02 ` [PATCHv7 net-next 2/6] net: ibm: emac: remove custom init/exit functions Rosen Penev
2024-10-17 8:58 ` Simon Horman
2024-10-19 14:54 ` kernel test robot
2024-10-15 20:02 ` [PATCHv7 net-next 3/6] net: ibm: emac: use devm_platform_ioremap_resource Rosen Penev
2024-10-15 20:02 ` [PATCHv7 net-next 4/6] net: ibm: emac: use platform_get_irq Rosen Penev
2024-10-15 20:02 ` [PATCHv7 net-next 5/6] net: ibm: emac: use devm for mutex_init Rosen Penev
2024-10-17 8:58 ` Simon Horman
2024-10-15 20:02 ` [PATCHv7 net-next 6/6] net: ibm: emac: generate random MAC if not found Rosen Penev
2024-10-17 8:58 ` Simon Horman [this message]
2024-10-16 18:28 ` [PATCHv7 net-next 0/6] ibm: emac: more cleanups Rosen Penev
2024-10-16 18:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017085853.GR2162@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=clement.leger@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=george.mccollister@gmail$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rosenp@gmail$(echo .)com \
--cc=u.kleine-koenig@baylibre$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox