Subject: Re: [PATCH] net: stmmac: enable MAC after MTL configuring

From: Simon Horman <[email-masked]>
Date: Thu, 17 Oct 2024 11:18:57 +0100

On Mon, Oct 14, 2024 at 01:44:03PM +0800, [email-masked] wrote:
> From: "hailong.fan" <[email-masked]>
> 
> DMA maybe block while ETH is opening,
> Adjust the enable sequence, put the MAC enable last
> 
> Signed-off-by: hailong.fan <[email-masked]>

Hi,

I think that some more explanation of this is required.
Including if a problem has been observed, and if so under what
conditions. Or, if not, some background information on why
this adjustment is correct.

I also think some explanation is required of the relationship
between the changes this patch makes to setup, and the
changes it makes to start and stop.

...