Subject: Re: [PATCH iwl-next v3 1/2] ice: refactor "last" segment of DDP pkg

From: Simon Horman <[email-masked]>
Date: Sat, 19 Oct 2024 09:35:02 +0100

On Fri, Oct 18, 2024 at 04:17:36PM +0200, Przemek Kitszel wrote:
> Add ice_ddp_send_hunk() that buffers "sent FW hunk" calls to AQ in order
> to mark the "last" one in more elegant way. Next commit will add even
> more complicated "sent FW" flow, so it's better to untangle a bit before.
> 
> Note that metadata buffers were not skipped for NOT-@indicate_last
> segments, this is fixed now.
> 
> Minor:
>  + use ice_is_buffer_metadata() instead of open coding it in
>    ice_dwnld_cfg_bufs();
>  + ice_dwnld_cfg_bufs_no_lock() + dependencies were moved up a bit to have
>    better git-diff, as this function was rewritten (in terms of git-blame)
> 
> CC: Paul Greenwalt <[email-masked]>
> CC: Dan Nowlin <[email-masked]>
> CC: Ahmed Zaki <[email-masked]>
> CC: Simon Horman <[email-masked]>
> Reviewed-by: Michal Swiatkowski <[email-masked]>
> Tested-by: Pucha Himasekhar Reddy <[email-masked]> (A Contingent worker at Intel)
> Signed-off-by: Przemek Kitszel <[email-masked]>
> ---
> git: --inter-hunk-context=6
> 
> v3: added ice_ddp_send_ctx_set_err() to avoid "user" code setting
>     the ctx->err directly, fix kdoc warnings, removed redundant
>     assignement, typo fix, all thanks to Simon
> v2: fixed one kdoc warning

Thanks for the updates.

Reviewed-by: Simon Horman <[email-masked]>