From: Simon Horman <horms@kernel•org>
To: Lee Trager <lee@trager•us>
Cc: Alexander Duyck <alexanderduyck@fb•com>,
Jakub Kicinski <kuba@kernel•org>,
kernel-team@meta•com, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Jonathan Corbet <corbet@lwn•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Sanman Pradhan <sanmanpradhan@meta•com>,
Al Viro <viro@zeniv•linux.org.uk>,
Mohsin Bashir <mohsin.bashr@gmail•com>,
netdev@vger•kernel.org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v2 2/2] eth: fbnic: Add devlink dev flash support
Date: Sat, 26 Oct 2024 16:12:29 +0100 [thread overview]
Message-ID: <20241026151229.GG1507976@kernel.org> (raw)
In-Reply-To: <13229808-dde5-4805-b908-ce65c8b342b4@trager.us>
On Fri, Oct 25, 2024 at 03:32:32PM -0700, Lee Trager wrote:
>
> On 10/24/24 2:10 AM, Simon Horman wrote:
> > On Mon, Oct 21, 2024 at 06:42:24PM -0700, Lee Trager wrote:
> > > fbnic supports updating firmware using a PLDM image signed and distributed
> > > by Meta. PLDM images are written into stored flashed. Flashing does not
> > > interrupt operation.
> > >
> > > On host reboot the newly flashed UEFI driver will be used. To run new
> > > control or cmrt firmware the NIC must be power cycled.
> > >
> > > Signed-off-by: Lee Trager <lee@trager•us>
> > ...
> >
> > > diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c b/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> > ...
> >
> > > @@ -109,8 +110,274 @@ static int fbnic_devlink_info_get(struct devlink *devlink,
> > > return 0;
> > > }
> > >
> > > +/**
> > > + * fbnic_send_package_data - Send record package data to firmware
> > > + * @context: PLDM FW update structure
> > > + * @data: pointer to the package data
> > > + * @length: length of the package data
> > > + *
> > > + * Send a copy of the package data associated with the PLDM record matching
> > > + * this device to the firmware.
> > > + *
> > > + * Return: zero on success
> > > + * negative error code on failure
> > > + */
> > > +static int fbnic_send_package_data(struct pldmfw *context, const u8 *data,
> > > + u16 length)
> > > +{
> > > + struct device *dev = context->dev;
> > > +
> > > + /* Temp placeholder required by devlink */
> > > + dev_info(dev,
> > > + "Sending %u bytes of PLDM record package data to firmware\n",
> > > + length);
> > Could you clarify what is meant by "Temp placeholder" here and in
> > fbnic_send_component_table(). And what plans there might be for
> > a non-temporary solution.
>
> Temp placeholder may not have been the best wording here. pldmfw requires
> all ops to be defined as they are always called[1] when updating. fbnic has
> an info message here so its doing something but we have no current plans to
> expand on fbnic_send_package_data nor fbnic_finalize_update.
>
> [1]
> https://elixir.bootlin.com/linux/v6.12-rc4/source/lib/pldmfw/pldmfw.c#L723
Thanks for the clarification. Perhaps the wording could be improved,
but I don't think that needs to block progress.
Reviewed-by: Simon Horman <horms@kernel•org>
prev parent reply other threads:[~2024-10-26 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 2:34 [PATCH net-next 0/2] eth: fbnic: Add devlink dev flash support Lee Trager
2024-10-12 2:34 ` [PATCH net-next 1/2] eth: fbnic: Add mailbox support for PLDM updates Lee Trager
2024-10-14 11:05 ` Vadim Fedorenko
2024-10-12 2:34 ` [PATCH net-next 2/2] eth: fbnic: Add devlink dev flash support Lee Trager
2024-10-14 11:18 ` Vadim Fedorenko
2024-10-15 10:43 ` Simon Horman
2024-10-18 22:48 ` Lee Trager
2024-10-19 9:34 ` Simon Horman
2024-10-22 1:37 ` [PATCH net-next v2 0/2] " Lee Trager
2024-10-22 1:37 ` [PATCH net-next v2 1/2] eth: fbnic: Add mailbox support for PLDM updates Lee Trager
2024-10-26 15:12 ` Simon Horman
2024-10-22 1:42 ` [PATCH net-next v2 2/2] eth: fbnic: Add devlink dev flash support Lee Trager
2024-10-24 9:10 ` Simon Horman
2024-10-25 22:32 ` Lee Trager
2024-10-26 15:12 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026151229.GG1507976@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alexanderduyck@fb$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel-team@meta$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lee@trager$(echo .)us \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mohsin.bashr@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sanmanpradhan@meta$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox