From: Simon Horman <horms@kernel•org>
To: Yue Haibing <yuehaibing@huawei•com>
Cc: anthony.l.nguyen@intel•com, przemyslaw.kitszel@intel•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, ast@kernel•org, daniel@iogearbox•net,
hawk@kernel•org, john.fastabend@gmail•com,
maciej.fijalkowski@intel•com, vedang.patel@intel•com,
jithu.joseph@intel•com, andre.guedes@intel•com,
jacob.e.keller@intel•com, sven.auhagen@voleatech•de,
alexander.h.duyck@intel•com, intel-wired-lan@lists•osuosl.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
bpf@vger•kernel.org
Subject: Re: [PATCH v4 net-next 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
Date: Sat, 26 Oct 2024 16:37:26 +0100 [thread overview]
Message-ID: <20241026153726.GK1507976@kernel.org> (raw)
In-Reply-To: <20241026041249.1267664-2-yuehaibing@huawei.com>
On Sat, Oct 26, 2024 at 12:12:46PM +0800, Yue Haibing wrote:
> igc_xdp_run_prog() converts customed xdp action to a negative error code
> with the sk_buff pointer type which be checked with IS_ERR in
> igc_clean_rx_irq(). Remove this error pointer handing instead use plain
> int return value to fix this smatch warnings:
>
> drivers/net/ethernet/intel/igc/igc_main.c:2533
> igc_xdp_run_prog() warn: passing zero to 'ERR_PTR'
>
> Fixes: 26575105d6ed ("igc: Add initial XDP support")
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel•com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel•com>
> Signed-off-by: Yue Haibing <yuehaibing@huawei•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-10-26 15:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 4:12 [PATCH v4 net-next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers Yue Haibing
2024-10-26 4:12 ` [PATCH v4 net-next 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog() Yue Haibing
2024-10-26 15:37 ` Simon Horman [this message]
2024-11-06 13:22 ` [Intel-wired-lan] " Avigail Dahan
2024-10-26 4:12 ` [PATCH v4 net-next 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp() Yue Haibing
2024-10-26 15:37 ` Simon Horman
2024-11-12 12:26 ` [Intel-wired-lan] " Rout, ChandanX
2024-10-26 4:12 ` [PATCH v4 net-next 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp() Yue Haibing
2024-10-26 15:37 ` Simon Horman
2024-11-12 12:25 ` [Intel-wired-lan] " Rout, ChandanX
2024-10-26 4:12 ` [PATCH v4 net-next 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp() Yue Haibing
2024-10-26 15:38 ` Simon Horman
2024-11-12 12:22 ` [Intel-wired-lan] " Rout, ChandanX
2024-10-29 14:44 ` [PATCH v4 net-next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers Jakub Kicinski
2024-10-29 18:37 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026153726.GK1507976@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=andre.guedes@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jithu.joseph@intel$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=sven.auhagen@voleatech$(echo .)de \
--cc=vedang.patel@intel$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox