Subject: Re: [PATCH net-next v2] eth: fbnic: Add support to write TCE TCAM entries

From: Jakub Kicinski <[email-masked]>
Date: Mon, 28 Oct 2024 16:35:54 -0700

On Fri, 25 Oct 2024 17:19:03 +0200 Alexander Lobakin wrote:
> > +static void fbnic_clear_tce_tcam_entry(struct fbnic_dev *fbd, unsigned int idx)
> > +{
> > +	int i;
> > +
> > +	/* Invalidate entry and clear addr state info */
> > +	for (i = 0; i <= FBNIC_TCE_TCAM_WORD_LEN; i++)  
> 
> Please declare loop iterators right in loop declarations, we're GNU11
> for a couple years already.
> 
> 	for (u32 i = 0; ...

Why?

Please avoid giving people subjective stylistic feedback, especially
when none of the maintainers have given such feedback in the past.

> (+ don't use signed when it can't be < 0)

Again, why. int is the most basic type in C, why is using a fixed side
kernel type necessary here?