Subject: Re: [PATCH 2/2][next] net: ethtool: Avoid thousands of -Wflex-array-member-not-at-end warnings

From: Jakub Kicinski <[email-masked]>
Date: Mon, 28 Oct 2024 17:32:48 -0700

On Mon, 28 Oct 2024 17:32:53 -0600 Gustavo A. R. Silva wrote:
> >> Additionally, update the type of some variables in various functions
> >> that don't access the flexible-array member, changing them to the
> >> newly created `struct ethtool_link_settings_hdr`.  
> > 
> > Why? Please avoid unnecessary code changes.  
> 
> This is actually necessary. As the type of the conflicting middle members
> changed, those instances that expect the type to be `struct ethtool_link_settings`
> should be adjusted to the new type. Another option is to leave the type
> unchanged and instead use container_of. See below.

Ah, that makes sense. So they need to be included int the newly split
patch. Please rephrase the commit message a bit, the current paragraph
reads as if this was a code cleanup.