From: Jakub Kicinski <kuba@kernel•org>
To: Breno Leitao <leitao@debian•org>
Cc: horms@kernel•org, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, thepacketgeek@gmail•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
davej@codemonkey•org.uk, vlad.wing@gmail•com, max@kutsevol•com,
kernel-team@meta•com, jiri@resnulli•us, jv@jvosburgh•net,
andy@greyhouse•net, aehkn@xenhub•one,
Rik van Riel <riel@surriel•com>,
Al Viro <viro@zeniv•linux.org.uk>
Subject: Re: [PATCH net-next 1/3] net: netpoll: Defer skb_pool population until setup success
Date: Thu, 31 Oct 2024 18:26:47 -0700 [thread overview]
Message-ID: <20241031182647.3fbb2ac4@kernel.org> (raw)
In-Reply-To: <20241025142025.3558051-2-leitao@debian.org>
On Fri, 25 Oct 2024 07:20:18 -0700 Breno Leitao wrote:
> The current implementation has a flaw where it populates the skb_pool
> with 32 SKBs before calling __netpoll_setup(). If the setup fails, the
> skb_pool buffer will persist indefinitely and never be cleaned up.
>
> This change moves the skb_pool population to after the successful
> completion of __netpoll_setup(), ensuring that the buffers are not
> unnecessarily retained. Additionally, this modification alleviates rtnl
> lock pressure by allowing the buffer filling to occur outside of the
> lock.
arguably if the setup succeeds there would now be a window of time
where np is active but pool is empty.
next prev parent reply other threads:[~2024-11-01 1:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 14:20 [PATCH net-next 0/3] net: netpoll: Improve SKB pool management Breno Leitao
2024-10-25 14:20 ` [PATCH net-next 1/3] net: netpoll: Defer skb_pool population until setup success Breno Leitao
2024-11-01 1:26 ` Jakub Kicinski [this message]
2024-11-01 10:51 ` Breno Leitao
2024-11-01 18:18 ` Breno Leitao
2024-11-02 2:01 ` Jakub Kicinski
2024-11-04 20:40 ` Breno Leitao
2024-11-06 1:00 ` Jakub Kicinski
2024-11-06 15:06 ` Breno Leitao
2024-11-06 23:43 ` Jakub Kicinski
2024-11-07 11:50 ` Breno Leitao
2024-10-25 14:20 ` [PATCH net-next 2/3] net: netpoll: Individualize the skb pool Breno Leitao
2024-11-01 1:28 ` Jakub Kicinski
2024-11-01 11:56 ` Breno Leitao
2024-10-25 14:20 ` [PATCH net-next 3/3] net: netpoll: flush skb pool during cleanup Breno Leitao
2024-11-01 1:29 ` Jakub Kicinski
2024-11-01 11:57 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031182647.3fbb2ac4@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aehkn@xenhub$(echo .)one \
--cc=andy@greyhouse$(echo .)net \
--cc=davej@codemonkey$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jiri@resnulli$(echo .)us \
--cc=jv@jvosburgh$(echo .)net \
--cc=kernel-team@meta$(echo .)com \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=max@kutsevol$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=riel@surriel$(echo .)com \
--cc=thepacketgeek@gmail$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=vlad.wing@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox