Subject: Re: [PATCH v3 iwl-net 0/4] Fix E825 initialization

From: Simon Horman <[email-masked]>
Date: Sat, 2 Nov 2024 15:12:36 +0000

On Tue, Oct 29, 2024 at 09:33:32AM +0100, Przemek Kitszel wrote:
> On 10/28/24 21:45, Grzegorz Nitka wrote:
> > E825 products have incorrect initialization procedure, which may lead to
> > initialization failures and register values.
> > 
> > Fix E825 products initialization by adding correct sync delay, checking
> > the PHY revision only for current PHY and adding proper destination
> > device when reading port/quad.
> > 
> > In addition, E825 uses PF ID for indexing per PF registers and as
> > a primary PHY lane number, which is incorrect.
> > 
> > Karol Kolacinski (4):
> >    ice: Fix E825 initialization
> >    ice: Fix quad registers read on E825
> >    ice: Fix ETH56G FC-FEC Rx offset value
> >    ice: Add correct PHY lane assignment
> 
> Grzegorz, thank you for picking this series up!
> It is legally required that you sign-off too, but please wait for other
> feedback instead of rushing with re-send ;)

Likewise, thanks Grzegorz.

FWIIW, I've provided some feedback on patch 2/4.
And the rest of the series looks good to me.