From: Arnd Bergmann <arnd@kernel•org>
To: Jian Shen <shenjian15@huawei•com>, Salil Mehta <salil.mehta@huawei•com>
Cc: Arnd Bergmann <arnd@arndb•de>, Will Deacon <will@kernel•org>,
Joerg Roedel <jroedel@suse•de>,
Robin Murphy <robin.murphy@arm•com>,
iommu@lists•linux.dev, Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jijie Shao <shaojijie@huawei•com>,
Peiyang Wang <wangpeiyang1@huawei•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: [PATCH] [net-next] net: hns3: add IOMMU_SUPPORT dependency
Date: Mon, 4 Nov 2024 09:21:21 +0100 [thread overview]
Message-ID: <20241104082129.3142694-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb•de>
The hns3 driver started filling iommu_iotlb_gather structures itself,
which requires CONFIG_IOMMU_SUPPORT is enabled:
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c: In function 'hns3_dma_map_sync':
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:395:14: error: 'struct iommu_iotlb_gather' has no member named 'start'
395 | iotlb_gather.start = iova;
| ^
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:396:14: error: 'struct iommu_iotlb_gather' has no member named 'end'
396 | iotlb_gather.end = iova + granule - 1;
| ^
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:397:14: error: 'struct iommu_iotlb_gather' has no member named 'pgsize'
397 | iotlb_gather.pgsize = granule;
| ^
Add a Kconfig dependency to make it build in random configurations.
Cc: Will Deacon <will@kernel•org>
Cc: Joerg Roedel <jroedel@suse•de>
Cc: Robin Murphy <robin.murphy@arm•com>
Cc: iommu@lists•linux.dev
Fixes: f2c14899caba ("net: hns3: add sync command to sync io-pgtable")
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
I noticed that no other driver does this, so it would be good to
have a confirmation from the iommu maintainers that this is how
the interface and the dependency is intended to be used.
---
drivers/net/ethernet/hisilicon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
index 65302c41bfb1..790efc8d2de6 100644
--- a/drivers/net/ethernet/hisilicon/Kconfig
+++ b/drivers/net/ethernet/hisilicon/Kconfig
@@ -91,6 +91,7 @@ config HNS_ENET
config HNS3
tristate "Hisilicon Network Subsystem Support HNS3 (Framework)"
depends on PCI
+ depends on IOMMU_SUPPORT
select NET_DEVLINK
select PAGE_POOL
help
--
2.39.5
next reply other threads:[~2024-11-04 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 8:21 Arnd Bergmann [this message]
2024-11-04 10:29 ` [PATCH] [net-next] net: hns3: add IOMMU_SUPPORT dependency Robin Murphy
2024-11-04 10:40 ` Salil Mehta
2024-11-04 10:50 ` Salil Mehta
2024-11-04 16:34 ` Robin Murphy
2024-11-06 19:39 ` Salil Mehta
2024-11-04 12:01 ` Pranjal Shrivastava
2024-11-05 2:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104082129.3142694-1-arnd@kernel.org \
--to=arnd@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jroedel@suse$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=shaojijie@huawei$(echo .)com \
--cc=shenjian15@huawei$(echo .)com \
--cc=wangpeiyang1@huawei$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox