From: Jakub Kicinski <kuba@kernel•org>
To: Meghana Malladi <m-malladi@ti•com>
Cc: <vigneshr@ti•com>, <horms@kernel•org>, <jan.kiszka@siemens•com>,
<diogo.ivo@siemens•com>, <pabeni@redhat•com>,
<edumazet@google•com>, <davem@davemloft•net>,
<andrew+netdev@lunn•ch>, <linux-kernel@vger•kernel.org>,
<netdev@vger•kernel.org>, <linux-arm-kernel@lists•infradead.org>,
<srk@ti•com>, Roger Quadros <rogerq@kernel•org>,
<danishanwar@ti•com>
Subject: Re: [PATCH net v4] net: ti: icssg-prueth: Fix 1 PPS sync
Date: Thu, 7 Nov 2024 11:15:42 -0800 [thread overview]
Message-ID: <20241107111542.19dc55e2@kernel.org> (raw)
In-Reply-To: <20241106072314.3361048-1-m-malladi@ti.com>
On Wed, 6 Nov 2024 12:53:14 +0530 Meghana Malladi wrote:
> +static inline __u64 icssg_readq(const void __iomem *addr)
two nit picks:
- since the function is now fairly special purpose I think a name less
generic than readq would be appropriate. Maybe icssg_read_time() ?
- __u64 is for uAPI, to avoid type name conflicts, in the kernel
please use u64 without the underscores
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-07 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 7:23 [PATCH net v4] net: ti: icssg-prueth: Fix 1 PPS sync Meghana Malladi
2024-11-07 19:15 ` Jakub Kicinski [this message]
2024-11-11 10:12 ` Meghana Malladi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107111542.19dc55e2@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=diogo.ivo@siemens$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jan.kiszka@siemens$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m-malladi@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rogerq@kernel$(echo .)org \
--cc=srk@ti$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox