From: Leon Romanovsky <leon@kernel•org>
To: Sanman Pradhan <sanman.p211993@gmail•com>
Cc: netdev@vger•kernel.org, alexanderduyck@fb•com, kuba@kernel•org,
kernel-team@meta•com, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, horms@kernel•org, corbet@lwn•net,
mohsin.bashr@gmail•com, sanmanpradhan@meta•com,
andrew+netdev@lunn•ch, vadim.fedorenko@linux•dev,
jdamato@fastly•com, sdf@fomichev•me, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org, Bjorn Helgaas <helgaas@kernel•org>,
linux-pci@vger•kernel.org
Subject: Re: [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics
Date: Thu, 7 Nov 2024 13:23:39 +0200 [thread overview]
Message-ID: <20241107112339.GJ5006@unreal> (raw)
In-Reply-To: <20241107020555.321245-1-sanman.p211993@gmail.com>
On Wed, Nov 06, 2024 at 06:05:55PM -0800, Sanman Pradhan wrote:
> Add PCIe hardware statistics support to the fbnic driver. These stats
> provide insight into PCIe transaction performance and error conditions.
>
> Which includes, read/write and completion TLP counts and DWORD counts and
> debug counters for tag, completion credit and NP credit exhaustion
>
> The stats are exposed via ethtool and can be used to monitor PCIe
> performance and debug PCIe issues.
>
> Signed-off-by: Sanman Pradhan <sanman.p211993@gmail•com>
> ---
> v1:
> - https://patchwork.kernel.org/project/netdevbpf/patch/20241106002625.1857904-1-sanman.p211993@gmail.com/
> - Removed unnecessary code blocks
> - Rephrased the commit message
> ---
> .../device_drivers/ethernet/meta/fbnic.rst | 27 +++++
> drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 39 ++++++
> .../net/ethernet/meta/fbnic/fbnic_ethtool.c | 77 +++++++++++-
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.c | 114 ++++++++++++++++++
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.h | 12 ++
> .../net/ethernet/meta/fbnic/fbnic_netdev.c | 3 +
> drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 2 +
> 7 files changed, 272 insertions(+), 2 deletions(-)
You completely ignored discussion and participants in v1 about
providing general solution which is applicable to all PCI devices
in the world.
Thanks
next prev parent reply other threads:[~2024-11-07 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 2:05 [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics Sanman Pradhan
2024-11-07 11:23 ` Leon Romanovsky [this message]
2024-11-07 18:20 ` Jakub Kicinski
2024-11-08 22:37 ` Sanman Pradhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107112339.GJ5006@unreal \
--to=leon@kernel$(echo .)org \
--cc=alexanderduyck@fb$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=kernel-team@meta$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=mohsin.bashr@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sanman.p211993@gmail$(echo .)com \
--cc=sanmanpradhan@meta$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox