From: Simon Horman <horms@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, joel.granados@kernel•org
Subject: Re: [PATCH net-next] net/neighbor: clear error in case strict check is not set
Date: Fri, 15 Nov 2024 14:06:14 +0000 [thread overview]
Message-ID: <20241115140614.GS1062410@kernel.org> (raw)
In-Reply-To: <20241115003221.733593-1-kuba@kernel.org>
On Thu, Nov 14, 2024 at 04:32:21PM -0800, Jakub Kicinski wrote:
> Commit 51183d233b5a ("net/neighbor: Update neigh_dump_info for strict
> data checking") added strict checking. The err variable is not cleared,
> so if we find no table to dump we will return the validation error even
> if user did not want strict checking.
>
> I think the only way to hit this is to send an buggy request, and ask
> for a table which doesn't exist, so there's no point treating this
> as a real fix. I only noticed it because a syzbot repro depended on it
> to trigger another bug.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> CC: joel.granados@kernel•org
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-11-15 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 0:32 [PATCH net-next] net/neighbor: clear error in case strict check is not set Jakub Kicinski
2024-11-15 14:06 ` Simon Horman [this message]
2024-11-19 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115140614.GS1062410@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=joel.granados@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox