From: Simon Horman <horms@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, alexanderduyck@fb•com, kernel-team@meta•com
Subject: Re: [PATCH net] eth: fbnic: don't disable the PCI device twice
Date: Fri, 15 Nov 2024 14:57:07 +0000 [thread overview]
Message-ID: <20241115145707.GU1062410@kernel.org> (raw)
In-Reply-To: <20241115014809.754860-1-kuba@kernel.org>
On Thu, Nov 14, 2024 at 05:48:09PM -0800, Jakub Kicinski wrote:
> We use pcim_enable_device(), there is no need to call pci_disable_device().
>
> Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-11-15 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 1:48 [PATCH net] eth: fbnic: don't disable the PCI device twice Jakub Kicinski
2024-11-15 14:57 ` Simon Horman [this message]
2024-11-19 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115145707.GU1062410@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alexanderduyck@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel-team@meta$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox