Subject: Re: [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors

From: Jakub Kicinski <[email-masked]>
Date: Sat, 23 Nov 2024 18:50:24 -0800

On Wed, 20 Nov 2024 08:04:35 +0200 Gal Pressman wrote:
> > The comment just says not to add what's already counted in missed,
> > because profcs adds the two and we'd end up double counting.  
> 
> So this is a procfs thing only?
> Does that mean that netlink's rx_dropped might be different than procfs'
> rx_dropped?

Yes, procfs and rtnl show "different" stats.
For more context on why I put the comment there -- some stats 
the drivers are supposed to fold (error stats from memory).

Legacy stats are tricky, it'd be a major review time investment 
to try to improve them..