From: Jakub Kicinski <kuba@kernel•org>
To: Lenny Szubowicz <lszubowi@redhat•com>
Cc: pavan.chebbi@broadcom•com, mchan@broadcom•com,
andrew+netdev@lunn•ch, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, george.shuklin@gmail•com,
andrea.fois@eventsense•it, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [patch v2] tg3: Disable tg3 PCIe AER on system reboot
Date: Mon, 2 Dec 2024 14:57:03 -0800 [thread overview]
Message-ID: <20241202145703.388913d1@kernel.org> (raw)
In-Reply-To: <20241129203640.54492-1-lszubowi@redhat.com>
On Fri, 29 Nov 2024 15:36:40 -0500 Lenny Szubowicz wrote:
> Disable PCIe AER on the tg3 device on system reboot on a limited
> list of Dell PowerEdge systems. This prevents a fatal PCIe AER event
> on the tg3 device during the ACPI _PTS (prepare to sleep) method for
> S5 on those systems. The _PTS is invoked by acpi_enter_sleep_state_prep()
> as part of the kernel's reboot sequence as a result of commit
> 38f34dba806a ("PM: ACPI: reboot: Reinstate S5 for reboot").
>
> There was an earlier fix for this problem by commit 2ca1c94ce0b6
> ("tg3: Disable tg3 device on system reboot to avoid triggering AER").
> But it was discovered that this earlier fix caused a reboot hang
> when some Dell PowerEdge servers were booted via ipxe. To address
> this reboot hang, the earlier fix was essentially reverted by commit
> 9fc3bc764334 ("tg3: power down device only on SYSTEM_POWER_OFF").
> This re-exposed the tg3 PCIe AER on reboot problem.
>
> This fix is not an ideal solution because the root cause of the AER
> is in system firmware. Instead, it's a targeted work-around in the
> tg3 driver.
>
> Note also that the PCIe AER must be disabled on the tg3 device even
> if the system is configured to use "firmware first" error handling.
sparse (make C=1) complains:
drivers/net/ethernet/broadcom/tg3.c:18259:22: warning: restricted pci_power_t degrades to integer
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-02 22:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 20:36 [patch v2] tg3: Disable tg3 PCIe AER on system reboot Lenny Szubowicz
2024-12-02 7:00 ` Pavan Chebbi
2025-01-30 19:40 ` Lenny Szubowicz
2024-12-02 22:57 ` Jakub Kicinski [this message]
2025-01-30 21:57 ` [PATCH net v3] " Lenny Szubowicz
2025-01-31 5:08 ` Pavan Chebbi
2025-01-31 9:42 ` Simon Horman
2025-02-03 10:20 ` patchwork-bot+netdevbpf
2025-01-31 12:56 ` [patch v2] " Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202145703.388913d1@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrea.fois@eventsense$(echo .)it \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=george.shuklin@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lszubowi@redhat$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox