Subject: Re: [PATCH net-next v1 3/7] tools/net/ynl: support decoding C arrays as enums

From: Jakub Kicinski <[email-masked]>
Date: Tue, 3 Dec 2024 18:03:20 -0800

On Tue,  3 Dec 2024 13:06:51 +0000 Donald Hunter wrote:
> Add support for translating arrays of scalars into enum names.

But not formatting hints.. ? ;) 

> Signed-off-by: Donald Hunter <[email-masked]>
> ---
>  tools/net/ynl/lib/ynl.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
> index 0d39a83574d5..f07a8404f71a 100644
> --- a/tools/net/ynl/lib/ynl.py
> +++ b/tools/net/ynl/lib/ynl.py
> @@ -627,6 +627,8 @@ class YnlFamily(SpecFamily):
>              decoded = self._decode_struct(attr.raw, attr_spec.struct_name)
>          elif attr_spec.sub_type:
>              decoded = attr.as_c_array(attr_spec.sub_type)
> +            if 'enum' in attr_spec:
> +                decoded = [ self._decode_enum(x, attr_spec) for x in decoded]

nit: missing space after 'decoded' or extra space before self, with
that fixed:

Acked-by: Jakub Kicinski <[email-masked]>