From: Simon Horman <horms@kernel•org>
To: Breno Leitao <leitao@debian•org>
Cc: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Shuah Khan <shuah@kernel•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-kselftest@vger•kernel.org
Subject: Re: [PATCH net-next 3/4] netconsole: selftest: Delete all userdata keys
Date: Fri, 6 Dec 2024 15:11:48 +0000 [thread overview]
Message-ID: <20241206151148.GX2581@kernel.org> (raw)
In-Reply-To: <20241204-netcons_overflow_test-v1-3-a85a8d0ace21@debian.org>
On Wed, Dec 04, 2024 at 08:40:44AM -0800, Breno Leitao wrote:
> Modify the cleanup function to remove all userdata keys created during the
> test, instead of just deleting a single predefined key. This ensures a
> more thorough cleanup of temporary resources.
>
> Move the KEY_PATH variable definition inside the set_user_data function
> to reduce global variables and improve encapsulation. The KEY_PATH
> variable is now dynamically created when setting user data.
>
> This change has no effect on the current test, while improving an
> upcoming test that would create several userdata entries.
>
> Signed-off-by: Breno Leitao <leitao@debian•org>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-12-06 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 16:40 [PATCH net-next 0/4] netconsole: selftest for userdata overflow Breno Leitao
2024-12-04 16:40 ` [PATCH net-next 1/4] netconsole: Warn if MAX_USERDATA_ITEMS limit is exceeded Breno Leitao
2024-12-06 15:11 ` Simon Horman
2024-12-04 16:40 ` [PATCH net-next 2/4] netconsole: selftest: Split the helpers from the selftest Breno Leitao
2024-12-06 15:11 ` Simon Horman
2024-12-04 16:40 ` [PATCH net-next 3/4] netconsole: selftest: Delete all userdata keys Breno Leitao
2024-12-06 15:11 ` Simon Horman [this message]
2024-12-04 16:40 ` [PATCH net-next 4/4] netconsole: selftest: verify userdata entry limit Breno Leitao
2024-12-06 15:09 ` Simon Horman
2025-01-03 11:48 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206151148.GX2581@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox