Subject: Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

From: Simon Horman <[email-masked]>
Date: Mon, 16 Dec 2024 16:12:06 +0000

On Sun, Dec 15, 2024 at 02:26:18AM +0000, [email-masked] wrote:
> From: "Dr. David Alan Gilbert" <[email-masked]>
> 
> hippi_neigh_setup_dev() has been unused since
> commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")
> 
> Remove it.
> 
> (I'm a little suspicious it's the only setup call removed
> by that previous commit?)
> 
> Signed-off-by: Dr. David Alan Gilbert <[email-masked]>

Hi David,

There is a dangling comment referring to hippi_neigh_setup_dev
in hippi_setup().

	/*
	 * HIPPI doesn't support broadcast+multicast and we only use
	 * static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
	 */

Could you fix that up too?

pw-bot: changes-requested