From: Jakub Kicinski <kuba@kernel•org>
To: Taehee Yoo <ap420073@gmail•com>
Cc: davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
almasrymina@google•com, donald.hunter@gmail•com, corbet@lwn•net,
michael.chan@broadcom•com, andrew+netdev@lunn•ch,
hawk@kernel•org, ilias.apalodimas@linaro•org, ast@kernel•org,
daniel@iogearbox•net, john.fastabend@gmail•com, dw@davidwei•uk,
sdf@fomichev•me, asml.silence@gmail•com, brett.creeley@amd•com,
linux-doc@vger•kernel.org, netdev@vger•kernel.org,
kory.maincent@bootlin•com, maxime.chevallier@bootlin•com,
danieller@nvidia•com, hengqi@linux•alibaba.com,
ecree.xilinx@gmail•com, przemyslaw.kitszel@intel•com,
hkallweit1@gmail•com, ahmed.zaki@intel•com,
rrameshbabu@nvidia•com, idosch@nvidia•com, jiri@resnulli•us,
bigeasy@linutronix•de, lorenzo@kernel•org, jdamato@fastly•com,
aleksander.lobakin@intel•com, kaiyuanz@google•com,
willemb@google•com, daniel.zahka@gmail•com,
Andy Gospodarek <gospo@broadcom•com>
Subject: Re: [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command
Date: Wed, 18 Dec 2024 18:40:00 -0800 [thread overview]
Message-ID: <20241218184000.54831119@kernel.org> (raw)
In-Reply-To: <20241218144530.2963326-6-ap420073@gmail.com>
On Wed, 18 Dec 2024 14:45:26 +0000 Taehee Yoo wrote:
> +#define BNXT_HDS_THRESHOLD_MAX 1023
> + u16 hds_threshold;
How about we add hds_threshold to struct ethtool_netdev_state ?
That way in patch 6 we don't have to call the driver to get it.
next prev parent reply other threads:[~2024-12-19 2:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 14:45 [PATCH net-next v6 0/9] bnxt_en: implement tcp-data-split and thresh option Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 1/9] bnxt_en: add support for rx-copybreak ethtool command Taehee Yoo
2024-12-19 2:07 ` Jakub Kicinski
2024-12-19 13:24 ` Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 2/9] net: ethtool: add hds_config member in ethtool_netdev_state Taehee Yoo
2024-12-19 2:16 ` Jakub Kicinski
2024-12-18 14:45 ` [PATCH net-next v6 3/9] bnxt_en: add support for tcp-data-split ethtool command Taehee Yoo
2024-12-19 2:25 ` Jakub Kicinski
2024-12-19 2:41 ` Jakub Kicinski
2024-12-19 14:05 ` Taehee Yoo
2024-12-19 14:29 ` Jakub Kicinski
2024-12-19 15:14 ` Taehee Yoo
2024-12-19 15:25 ` Jakub Kicinski
2024-12-19 19:33 ` Andy Gospodarek
2024-12-19 20:18 ` Jakub Kicinski
2024-12-19 23:41 ` Michael Chan
2024-12-20 2:08 ` Jakub Kicinski
2024-12-18 14:45 ` [PATCH net-next v6 4/9] net: ethtool: add support for configuring hds-thresh Taehee Yoo
2024-12-19 2:35 ` Jakub Kicinski
2024-12-19 14:10 ` Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command Taehee Yoo
2024-12-19 2:40 ` Jakub Kicinski [this message]
2024-12-19 14:12 ` Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 6/9] net: devmem: add ring parameter filtering Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 7/9] net: ethtool: " Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled Taehee Yoo
2024-12-19 2:44 ` Jakub Kicinski
2024-12-19 14:14 ` Taehee Yoo
2024-12-18 14:45 ` [PATCH net-next v6 9/9] netdevsim: add HDS feature Taehee Yoo
2024-12-19 2:49 ` Jakub Kicinski
2024-12-19 14:37 ` Taehee Yoo
2024-12-19 14:45 ` Jakub Kicinski
2024-12-19 15:19 ` Taehee Yoo
2024-12-19 15:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218184000.54831119@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ap420073@gmail$(echo .)com \
--cc=asml.silence@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=brett.creeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=daniel.zahka@gmail$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dw@davidwei$(echo .)uk \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hengqi@linux$(echo .)alibaba.com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kaiyuanz@google$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox