Subject: Re: [PATCH net-next 1/3] net: phy: add phy_disable_eee

From: Jakub Kicinski <[email-masked]>
Date: Wed, 18 Dec 2024 18:59:09 -0800

On Tue, 17 Dec 2024 11:43:11 +0100 Andrew Lunn wrote:
> > @@ -2071,6 +2071,7 @@ void phy_advertise_eee_all(struct phy_device *phydev);
> >  void phy_support_sym_pause(struct phy_device *phydev);
> >  void phy_support_asym_pause(struct phy_device *phydev);
> >  void phy_support_eee(struct phy_device *phydev);
> > +void phy_disable_eee(struct phy_device *phydev);  
> 
> So we have three states:
> 
> MAC tells PHYLIB it does support EEE
> MAC tells PHYLIB it does not support EEE
> MAC says nothing.
> 
> Do we really want this?

Hi Andrew, do you feel convinced? I think I messed up merging some EEE
patches recently, an explicit Ack would boost my confidence..