From: Jakub Kicinski <kuba@kernel•org>
To: Oleksij Rempel <o.rempel@pengutronix•de>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Jonathan Corbet <corbet@lwn•net>,
kernel@pengutronix•de, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, Simon Horman <horms@kernel•org>,
Russell King <linux@armlinux•org.uk>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
linux-doc@vger•kernel.org
Subject: Re: [PATCH net-next v2 0/8] Introduce unified and structured PHY
Date: Thu, 19 Dec 2024 19:54:23 -0800 [thread overview]
Message-ID: <20241219195423.0bba4ac8@kernel.org> (raw)
In-Reply-To: <20241219132534.725051-1-o.rempel@pengutronix.de>
On Thu, 19 Dec 2024 14:25:26 +0100 Oleksij Rempel wrote:
> This patch set introduces a unified and well-structured interface for
> reporting PHY statistics. Instead of relying on arbitrary strings in PHY
> drivers, this interface provides a consistent and structured way to
> expose PHY statistics to userspace via ethtool.
>
> The initial groundwork for this effort was laid by Jakub Kicinski, who
> contributed patches to plumb PHY statistics to drivers and added support
> for structured statistics in ethtool. Building on Jakub's work, I tested
> the implementation with several PHYs, addressed a few issues, and added
> support for statistics in two specific PHY drivers.
>
> changes are tracked in separate patches.
At a glance looks like it doesn't pass allmodconfig build:
ld: vmlinux.o: in function `linkstate_prepare_data':
linkstate.c:(.text+0x21192f1): undefined reference to `phy_ethtool_get_link_ext_stats'
ld: vmlinux.o: in function `stats_prepare_data':
stats.c:(.text+0x212a66f): undefined reference to `phy_ethtool_get_phy_stats'
There are also kdoc warnings in patch 2.
--
pw-bot: cr
prev parent reply other threads:[~2024-12-20 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 13:25 [PATCH net-next v2 0/8] Introduce unified and structured PHY Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 1/8] ethtool: linkstate: migrate linkstate functions to support multi-PHY setups Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 2/8] net: ethtool: plumb PHY stats to PHY drivers Oleksij Rempel
2024-12-20 12:36 ` kernel test robot
2024-12-20 12:47 ` kernel test robot
2024-12-19 13:25 ` [PATCH net-next v2 3/8] net: ethtool: add support for structured PHY statistics Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 4/8] Documentation: networking: update PHY error counter diagnostics in twisted pair guide Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 5/8] net: phy: introduce optional polling interface for PHY statistics Oleksij Rempel
2024-12-19 13:33 ` Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 6/8] ethtool: add helper to prevent invalid statistics exposure to userspace Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 7/8] net: phy: dp83td510: add statistics support Oleksij Rempel
2024-12-19 13:25 ` [PATCH net-next v2 8/8] net: phy: dp83tg720: " Oleksij Rempel
2024-12-20 3:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219195423.0bba4ac8@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox