Subject: Re: [PATCH net-next v3 4/5] net: pcs: qcom-ipq9574: Add USXGMII interface mode support

From: Jakub Kicinski <[email-masked]>
Date: Fri, 20 Dec 2024 13:49:41 -0800

On Mon, 16 Dec 2024 21:40:26 +0800 Lei Wei wrote:
> +static int ipq_pcs_config_usxgmii(struct ipq_pcs *qpcs)
> +{
> +	int ret;
> +
> +	/* Configure the XPCS for USXGMII mode if required */
> +	if (qpcs->interface != PHY_INTERFACE_MODE_USXGMII) {

nit:

	if (qpcs->interface == PHY_INTERFACE_MODE_USXGMII)
		return 0;

And then the entire function doesn't have to be indented.

Please fix this and repost, it'd be great to get a review tag from
Russell or someone with more phylink knowledge.. Please be mindful of:
https://lore.kernel.org/all/[email-masked]/
-- 
pw-bot: cr