From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Ming Yu <a0282524688@gmail•com>
Cc: tmyu0@nuvoton•com, lee@kernel•org, linus.walleij@linaro•org,
brgl@bgdev•pl, andi.shyti@kernel•org, mkl@pengutronix•de,
mailhol.vincent@wanadoo•fr, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, wim@linux-watchdog•org, linux@roeck-us•net,
jdelvare@suse•com, linux-kernel@vger•kernel.org,
linux-gpio@vger•kernel.org, linux-i2c@vger•kernel.org,
linux-can@vger•kernel.org, netdev@vger•kernel.org,
linux-watchdog@vger•kernel.org, linux-hwmon@vger•kernel.org,
linux-rtc@vger•kernel.org
Subject: Re: [PATCH v4 7/7] rtc: Add Nuvoton NCT6694 RTC support
Date: Mon, 30 Dec 2024 16:39:36 +0100 [thread overview]
Message-ID: <2024123015393681ee26a3@mail.local> (raw)
In-Reply-To: <20241227095727.2401257-8-a0282524688@gmail.com>
On 27/12/2024 17:57:27+0800, Ming Yu wrote:
> + ret = devm_rtc_register_device(data->rtc);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "Failed to register rtc\n");
There is no error path where the error is silent in
devm_rtc_register_device, the message is unnecessary .
> +
> + device_init_wakeup(&pdev->dev, true);
> + return 0;
> +}
> +
> +static struct platform_driver nct6694_rtc_driver = {
> + .driver = {
> + .name = "nct6694-rtc",
> + },
> + .probe = nct6694_rtc_probe,
> +};
> +
> +module_platform_driver(nct6694_rtc_driver);
> +
> +MODULE_DESCRIPTION("USB-RTC driver for NCT6694");
> +MODULE_AUTHOR("Ming Yu <tmyu0@nuvoton•com>");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:nct6694-rtc");
> --
> 2.34.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-12-30 15:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 9:57 [PATCH v4 0/7] Add Nuvoton NCT6694 MFD drivers Ming Yu
2024-12-27 9:57 ` [PATCH v4 1/7] mfd: Add core driver for Nuvoton NCT6694 Ming Yu
2024-12-27 15:34 ` Vincent Mailhol
2024-12-30 6:32 ` Ming Yu
2024-12-30 7:33 ` Vincent Mailhol
2024-12-30 8:47 ` Ming Yu
2024-12-30 9:38 ` Vincent Mailhol
2024-12-27 9:57 ` [PATCH v4 2/7] gpio: Add Nuvoton NCT6694 GPIO support Ming Yu
2025-01-13 14:27 ` Linus Walleij
2024-12-27 9:57 ` [PATCH v4 3/7] i2c: Add Nuvoton NCT6694 I2C support Ming Yu
2024-12-27 9:57 ` [PATCH v4 4/7] can: Add Nuvoton NCT6694 CAN support Ming Yu
2024-12-27 15:59 ` Vincent Mailhol
2025-01-02 5:25 ` Ming Yu
2024-12-30 5:56 ` Vincent Mailhol
2025-01-02 5:40 ` Ming Yu
2025-01-02 9:03 ` Vincent Mailhol
2024-12-27 9:57 ` [PATCH v4 5/7] watchdog: Add Nuvoton NCT6694 WDT support Ming Yu
2024-12-27 9:57 ` [PATCH v4 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Ming Yu
2025-01-06 13:51 ` Simon Horman
2025-01-13 3:00 ` Ming Yu
2024-12-27 9:57 ` [PATCH v4 7/7] rtc: Add Nuvoton NCT6694 RTC support Ming Yu
2024-12-30 15:39 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024123015393681ee26a3@mail.local \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=a0282524688@gmail$(echo .)com \
--cc=andi.shyti@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=brgl@bgdev$(echo .)pl \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tmyu0@nuvoton$(echo .)com \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox