Subject: Re: [PATCH v9 12/27] sfc: set cxl media ready

From: Jonathan Cameron <[email-masked]>
Date: Thu, 2 Jan 2025 14:55:42 +0000

On Mon, 30 Dec 2024 21:44:30 +0000
<[email-masked]> wrote:

> From: Alejandro Lucero <[email-masked]>
> 
> Use cxl api accessor for explicitly set media ready as hardware design
> implies it is ready and there is no device register for stating so.
> 
> Signed-off-by: Alejandro Lucero <[email-masked]>
> Reviewed-by: Martin Habets <[email-masked]>
> Acked-by: Edward Cree <[email-masked]>
FWIW 

Reviewed-by: Jonathan Cameron <[email-masked]>

> ---
>  drivers/net/ethernet/sfc/efx_cxl.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 2031f08ee689..911f29b91bd3 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -91,6 +91,11 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  		goto err_resource_set;
>  	}
>  
> +	/* We do not have the register about media status. Hardware design
> +	 * implies it is ready.
> +	 */
> +	cxl_set_media_ready(cxl->cxlds);
> +
>  	probe_data->cxl = cxl;
>  
>  	return 0;