From: Furong Xu <0x1207@gmail•com>
To: Jason Xing <kerneljasonxing@gmail•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Jesper Dangaard Brouer <hawk@kernel•org>,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>
Subject: Re: [PATCH net-next v3] page_pool: check for dma_sync_size earlier
Date: Mon, 6 Jan 2025 11:31:23 +0800 [thread overview]
Message-ID: <20250106113123.0000384b@gmail.com> (raw)
In-Reply-To: <CAL+tcoBfZRNrHarZzmRh0ep+QrfZOntm82hECNb=aMO-FdmH8g@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GB18030, Size: 934 bytes --]
On Mon, 6 Jan 2025 11:15:45 +0800, Jason Xing <kerneljasonxing@gmail•com> wrote:
> On Mon, Jan 6, 2025 at 11:026§2AM Furong Xu <0x1207@gmail•com> wrote:
> >
> > Setting dma_sync_size to 0 is not illegal, fec_main.c and ravb_main.c
> > already did.
> > We can save a couple of function calls if check for dma_sync_size earlier.
> >
> > This is a micro optimization, about 0.6% PPS performance improvement
> > has been observed on a single Cortex-A53 CPU core with 64 bytes UDP RX
> > traffic test.
> >
> > Before this patch:
> > The average of packets per second is 234026 in one minute.
> >
> > After this patch:
> > The average of packets per second is 235537 in one minute.
>
> Sorry, I keep skeptical that this small improvement can be statically
> observed? What exact tool or benchmark are you using, I wonder?
A x86 PC send out UDP packet and the sar cmd from Sysstat package to report
the PPS on RX side:
sar -n DEV 60 1
next prev parent reply other threads:[~2025-01-06 3:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 3:02 [PATCH net-next v3] page_pool: check for dma_sync_size earlier Furong Xu
2025-01-06 3:15 ` Jason Xing
2025-01-06 3:31 ` Furong Xu [this message]
2025-01-09 10:09 ` Paolo Abeni
2025-01-09 15:44 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106113123.0000384b@gmail.com \
--to=0x1207@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=kerneljasonxing@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox