Subject: Re: [PATCH net-next v7 02/10] net: ethtool: add support for configuring hds-thresh

From: Jakub Kicinski <[email-masked]>
Date: Mon, 6 Jan 2025 18:48:54 -0800

On Fri,  3 Jan 2025 15:03:17 +0000 Taehee Yoo wrote:
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 4e451084d58a..8bab30e91022 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -78,6 +78,8 @@ enum {
>   * @cqe_size: Size of TX/RX completion queue event
>   * @tx_push_buf_len: Size of TX push buffer
>   * @tx_push_buf_max_len: Maximum allowed size of TX push buffer
> + * @hds_thresh: Threshold value of header-data-split-thresh
> + * @hds_thresh_max: Maximum supprted threshold of header-data-split-thresh

supprted -> supported

Maybe let's rephrase these as:

 * @hds_thresh: Packet size threshold for header data split (HDS)
 * @hds_thresh_max: Maximum supported setting for @hds_threshold

>   */

>   * @module_fw_flash_in_progress: Module firmware flashing is in progress.
> @@ -1141,6 +1148,7 @@ int ethtool_virtdev_set_link_ksettings(struct net_device *dev,
>  struct ethtool_netdev_state {
>  	struct xarray		rss_ctx;
>  	struct mutex		rss_lock;
> +	u32			hds_thresh;

this value is checked in devmem.c but nothing ever sets it.
net/ethtool/rings.c needs to handle it like it handles
dev->ethtool->hds_config

>  	u8			hds_config;
>  	unsigned		wol_enabled:1;
>  	unsigned		module_fw_flash_in_progress:1;
-- 
pw-bot: cr