Subject: Re: [PATCH v8 18/27] sfc: get endpoint decoder

From: Simon Horman <[email-masked]>
Date: Tue, 7 Jan 2025 11:34:19 +0000

On Wed, Dec 18, 2024 at 08:22:05AM +0000, Alejandro Lucero Palau wrote:
> 
> On 12/17/24 10:42, Simon Horman wrote:
> > On Mon, Dec 16, 2024 at 04:10:33PM +0000, [email-masked] wrote:
> > > From: Alejandro Lucero <[email-masked]>
> > > 
> > > Use cxl api for getting DPA (Device Physical Address) to use through an
> > > endpoint decoder.
> > > 
> > > Signed-off-by: Alejandro Lucero <[email-masked]>
> > > Reviewed-by: Martin Habets <[email-masked]>
> > > ---
> > >   drivers/net/ethernet/sfc/efx_cxl.c | 9 +++++++++
> > >   1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> > > index 253c82c61f43..724bca59b4d4 100644
> > > --- a/drivers/net/ethernet/sfc/efx_cxl.c
> > > +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> > > @@ -121,6 +121,14 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
> > >   		goto err_memdev;
> > >   	}
> > > +	cxl->cxled = cxl_request_dpa(cxl->cxlmd, true, EFX_CTPIO_BUFFER_SIZE,
> > > +				     EFX_CTPIO_BUFFER_SIZE);
> > > +	if (IS_ERR(cxl->cxled)) {
> > > +		pci_err(pci_dev, "CXL accel request DPA failed");
> > > +		rc = PTR_ERR(cxl->cxlrd);
> > Hi Alejandro,
> > 
> > Should the line above use cxl->cxled rather than cxl->cxlrd?
> 
> 
> Hi Simon,
> 
> 
> Of course. This one has gone through a lot of eyes undetected!
> 
> 
> BTW, apart from the fact that I should use Smatch from now on :-), out of
> curiosity, is Smatch only detecting one problem each time? Because this
> patch had another flagged issue in v7.

Hi Alejandro,

It does seem that this problem was also flagged when I ran Smatch of v7.
Sorry if I didn't pass that on at the time, it would have most likely
been an oversight on my part.

In general Smatch can flag more than one problem at a time :)