public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Leon Romanovsky <leon@kernel•org>
To: Kalesh AP <kalesh-anakkur.purayil@broadcom•com>
Cc: jgg@ziepe•ca, linux-rdma@vger•kernel.org, davem@davemloft•net,
	edumazet@google•com, kuba@kernel•org, netdev@vger•kernel.org,
	pabeni@redhat•com, andrew+netdev@lunn•ch,
	andrew.gospodarek@broadcom•com, selvin.xavier@broadcom•com,
	michael.chan@broadcom•com, pavan.chebbi@broadcom•com
Subject: Re: [PATCH rdma-next v2 RESEND 2/4] RDMA/bnxt_re: Add Async event handling support
Date: Tue, 7 Jan 2025 17:24:52 +0200	[thread overview]
Message-ID: <20250107152452.GE87447@unreal> (raw)
In-Reply-To: <20250107024553.2926983-3-kalesh-anakkur.purayil@broadcom.com>

On Tue, Jan 07, 2025 at 08:15:50AM +0530, Kalesh AP wrote:
> Using the option provided by Ethernet driver, register for FW Async
> event. During probe, while registeriung with Ethernet driver, provide
> the ulp hook 'ulp_async_notifier' for receiving the firmware events.
> 
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom•com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom•com>
> ---
>  drivers/infiniband/hw/bnxt_re/bnxt_re.h |  1 +
>  drivers/infiniband/hw/bnxt_re/main.c    | 47 +++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)

<...>

> +static void bnxt_re_net_unregister_async_event(struct bnxt_re_dev *rdev)
> +{
> +	int rc;
> +
> +	if (rdev->is_virtfn)
> +		return;
> +
> +	memset(&rdev->event_bitmap, 0, sizeof(rdev->event_bitmap));
> +	rc = bnxt_register_async_events(rdev->en_dev, &rdev->event_bitmap,
> +					ASYNC_EVENT_CMPL_EVENT_ID_DCB_CONFIG_CHANGE);
> +	if (rc)
> +		ibdev_err(&rdev->ibdev, "Failed to unregister async event");
> +}
> +
> +static void bnxt_re_net_register_async_event(struct bnxt_re_dev *rdev)
> +{
> +	int rc;
> +
> +	if (rdev->is_virtfn)
> +		return;
> +
> +	rdev->event_bitmap |= (1 << ASYNC_EVENT_CMPL_EVENT_ID_DCB_CONFIG_CHANGE);
> +	rc = bnxt_register_async_events(rdev->en_dev, &rdev->event_bitmap,
> +					ASYNC_EVENT_CMPL_EVENT_ID_DCB_CONFIG_CHANGE);
> +	if (rc)
> +		ibdev_err(&rdev->ibdev, "Failed to unregister async event");

s/Failed to unregister async event/Failed to register async event

If it is the only comment, we will get for this series. You don't need to resend, I'll fix it.

Thanks

> +}

next prev parent reply	other threads:[~2025-01-07 15:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07  2:45 [PATCH rdma-next v2 RESEND 0/4] RDMA/bnxt_re: Support for FW async event handling Kalesh AP
2025-01-07  2:45 ` [PATCH rdma-next v2 RESEND 1/4] bnxt_en: Add ULP call to notify async events Kalesh AP
2025-01-07  2:45 ` [PATCH rdma-next v2 RESEND 2/4] RDMA/bnxt_re: Add Async event handling support Kalesh AP
2025-01-07 15:24   ` Leon Romanovsky [this message]
2025-01-08  2:27     ` Kalesh Anakkur Purayil
2025-01-07  2:45 ` [PATCH rdma-next v2 RESEND 3/4] RDMA/bnxt_re: Query firmware defaults of CC params during probe Kalesh AP
2025-01-07  2:45 ` [PATCH rdma-next v2 RESEND 4/4] RDMA/bnxt_re: Add support to handle DCB_CONFIG_CHANGE event Kalesh AP
2025-01-14  9:05 ` [PATCH rdma-next v2 RESEND 0/4] RDMA/bnxt_re: Support for FW async event handling Leon Romanovsky
2025-01-15  4:01   ` Kalesh Anakkur Purayil
2025-01-14  9:08 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107152452.GE87447@unreal \
    --to=leon@kernel$(echo .)org \
    --cc=andrew+netdev@lunn$(echo .)ch \
    --cc=andrew.gospodarek@broadcom$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=jgg@ziepe$(echo .)ca \
    --cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-rdma@vger$(echo .)kernel.org \
    --cc=michael.chan@broadcom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=pavan.chebbi@broadcom$(echo .)com \
    --cc=selvin.xavier@broadcom$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox