Subject: Re: [PATCH][Resend][net-next] net: ethtool: Use hwprov under rcu_read_lock

From: Jakub Kicinski <[email-masked]>
Date: Tue, 7 Jan 2025 17:40:45 -0800

On Tue, 7 Jan 2025 17:39:43 -0800 Jakub Kicinski wrote:
> On Sun,  5 Jan 2025 16:40:52 +0800 Li RongQing wrote:
> > hwprov should be protected by rcu_read_lock to prevent possible UAF
> > 
> > Fixes: 4c61d809cf60 ("net: ethtool: Fix suspicious rcu_dereference usage")
> > Signed-off-by: Li RongQing <[email-masked]>  
> 
> In the future please make sure you CC the appropriate authors and
> maintainers. Always use get_maintainer.pl on the generated patch file.

Actually, the code could be improved, too.

Don't declare ret, move the declaration of int err instead.
-- 
pw-bot: cr