Subject: Re: [PATCH net v2] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac_address"

From: Jakub Kicinski <[email-masked]>
Date: Wed, 8 Jan 2025 19:16:49 -0800

On Thu, 09 Jan 2025 00:48:07 +0300 Ivan Mikhaylov wrote:
> Common case is 1 NCSI interface for server, we tested on this one and
> works fine for us and that's the reason why we didn't catch that
> situation. Nowadays some new servers has more than one NCSI interface.
> Probably we missed that is softirq context which is obviously not a
> place for rtnl_lock/unlock. Is there any other solution about except
> delaying dev_set_mac_address in work queue? Or any suggestions about
> how to deal with that in a proper way?

Nothing obvious comes to mind, unfortunately.
But the workqueue shouldn't be too bad.