From: Jakub Kicinski <kuba@kernel•org>
To: Carlos Llamas <cmllamas@google•com>
Cc: Li Li <dualli@chromium•org>,
dualli@google•com, corbet@lwn•net, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com, donald.hunter@gmail•com,
gregkh@linuxfoundation•org, arve@android•com, tkjos@android•com,
maco@android•com, joel@joelfernandes•org, brauner@kernel•org,
surenb@google•com, arnd@arndb•de, masahiroy@kernel•org,
bagasdotme@gmail•com, horms@kernel•org,
linux-kernel@vger•kernel.org, linux-doc@vger•kernel.org,
netdev@vger•kernel.org, hridya@google•com, smoreland@google•com,
kernel-team@android•com
Subject: Re: [PATCH v11 2/2] binder: report txn errors via generic netlink
Date: Thu, 9 Jan 2025 16:18:25 -0800 [thread overview]
Message-ID: <20250109161825.62b31b18@kernel.org> (raw)
In-Reply-To: <Z4BZjHjfanPi5h9W@google.com>
On Thu, 9 Jan 2025 23:19:40 +0000 Carlos Llamas wrote:
> On Thu, Jan 09, 2025 at 12:13:00PM -0800, Jakub Kicinski wrote:
> > On Thu, 9 Jan 2025 11:48:24 -0800 Li Li wrote:
> > > Cleaning up in the NETLINK_URELEASE notifier is better since we
> > > register the process with the netlink socket. I'll change the code
> > > accordingly.
> >
> > Hm. Thought I already told you this. Maybe I'm mixing up submissions.
> >
> > Please the unbind callback or possibly the sock priv infra
> > (genl_sk_priv_get, sock_priv_destroy etc).
>
> Sorry, it was me that suggested NETLINK_URELEASE. BTW, I did try those
> genl_family callbacks first but I couldn't get them to work right away
> so I moved on. I'll have a closer look now to figure out what I did
> wrong. Thanks for the suggestion Jakub!
Hm, that's probably because there is no real multicast group here :(
genl_sk_priv_get() and co. may work better in that case.
your suggestion of NETLINK_URELEASE may work too, tho, I think it's
the most error prone
next prev parent reply other threads:[~2025-01-10 0:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 20:37 [PATCH v11 0/2] binder: report txn errors via generic netlink Li Li
2024-12-18 20:37 ` [PATCH v11 1/2] binderfs: add new binder devices to binder_devices Li Li
2024-12-18 20:37 ` [PATCH v11 2/2] binder: report txn errors via generic netlink Li Li
2025-01-07 21:29 ` Carlos Llamas
2025-01-07 21:41 ` Carlos Llamas
2025-01-08 0:00 ` Li Li
2025-01-08 19:07 ` Carlos Llamas
2025-01-08 19:56 ` Li Li
2025-01-08 21:59 ` Carlos Llamas
2025-01-09 18:51 ` Carlos Llamas
2025-01-09 19:30 ` Carlos Llamas
2025-01-09 19:48 ` Li Li
2025-01-09 20:13 ` Jakub Kicinski
2025-01-09 23:19 ` Carlos Llamas
2025-01-10 0:18 ` Jakub Kicinski [this message]
2025-01-14 6:01 ` Li Li
2025-01-14 18:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109161825.62b31b18@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=arve@android$(echo .)com \
--cc=bagasdotme@gmail$(echo .)com \
--cc=brauner@kernel$(echo .)org \
--cc=cmllamas@google$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dualli@chromium$(echo .)org \
--cc=dualli@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=hridya@google$(echo .)com \
--cc=joel@joelfernandes$(echo .)org \
--cc=kernel-team@android$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maco@android$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=smoreland@google$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=tkjos@android$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox